]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: codecs: pcm3168a: Allow for 24-bit in provider mode
authorCezary Rojewski <cezary.rojewski@intel.com>
Mon, 3 Feb 2025 14:10:43 +0000 (15:10 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:13:41 +0000 (11:13 +0200)
[ Upstream commit 7d92a38d67e5d937b64b20aa4fd14451ee1772f3 ]

As per codec device specification, 24-bit is allowed in provider mode.
Update the code to reflect that.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250203141051.2361323-4-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/pcm3168a.c

index fac0617ab95b65ca07c689d072c039bac9b8a9de..6cbb8d0535b02e342ac29b8cefdf036df06439d2 100644 (file)
@@ -493,9 +493,9 @@ static int pcm3168a_hw_params(struct snd_pcm_substream *substream,
                }
                break;
        case 24:
-               if (provider_mode || (format == SND_SOC_DAIFMT_DSP_A) ||
-                                    (format == SND_SOC_DAIFMT_DSP_B)) {
-                       dev_err(component->dev, "24-bit slots not supported in provider mode, or consumer mode using DSP\n");
+               if (!provider_mode && ((format == SND_SOC_DAIFMT_DSP_A) ||
+                                      (format == SND_SOC_DAIFMT_DSP_B))) {
+                       dev_err(component->dev, "24-bit slots not supported in consumer mode using DSP\n");
                        return -EINVAL;
                }
                break;