]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib/util: do not make string_wrappers.h public
authorMatthew DeVore <matvore@google.com>
Fri, 7 Aug 2020 18:27:53 +0000 (11:27 -0700)
committerJeremy Allison <jra@samba.org>
Fri, 28 Aug 2020 00:56:34 +0000 (00:56 +0000)
string_wrappers.h is a collection of macros. All but one of the macros
rely on symbols not defined in public headers, so it is not useful as a
public header.

For instance, fstring is defined in includes.h. PTR_DIFF is defined in
lib/util/memory.h, which is not public.

checked_strlcpy is actually self-contained and is usable outside of a
Samba build, but without a Samba config.h, it is just aliased to
strlcpy.

Signed-off-by: Matthew DeVore <matvore@google.com>
Reviewed-by: David Mulder <dmulder@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
lib/util/wscript_build

index 0a730c17c88f286b8314589fd9471c7c3f19a0a5..7ae14130173ca028909b9f8054802d4c9beed322 100644 (file)
@@ -163,7 +163,6 @@ else:
                                  debug.h
                                  discard.h
                                  time.h
-                                 string_wrappers.h
                                  idtree.h
                                  idtree_random.h
                                  blocking.h