]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
monitor: send SIGTERM to the container when SIGHUP is received
authorTycho Andersen <tycho@tycho.ws>
Mon, 5 Feb 2018 14:17:48 +0000 (14:17 +0000)
committerTycho Andersen <tycho@tycho.ws>
Mon, 5 Feb 2018 14:17:48 +0000 (14:17 +0000)
For the ->execute() case, we want to make sure the application dies when
SIGHUP is received. The next patch will ignore SIGHUP in the lxc monitor,
because tasks inside the container send SIGHUP to init to have it reload
its config sometimes, and we don't want to do that with init.lxc, since it
might actually kill the container if it forwards SIGHUP to the child and
the child can't handle it.

Signed-off-by: Tycho Andersen <tycho@tycho.ws>
src/lxc/start.c

index d79fbe2395f473c1c2f5cd88f4479cfacea05f7e..ab928a91ddaa7c9bf144a6a4791507d87b97170c 100644 (file)
@@ -345,6 +345,12 @@ static int signal_handler(int fd, uint32_t events, void *data,
                }
        }
 
+       if (siginfo.ssi_signo == SIGHUP) {
+               kill(hdlr->pid, SIGTERM);
+               INFO("Killing %d since terminal hung up", hdlr->pid);
+               return hdlr->init_died ? LXC_MAINLOOP_CLOSE : 0;
+       }
+
        /* More robustness, protect ourself from a SIGCHLD sent
         * by a process different from the container init.
         */