]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selinux: fix sel_write_enforce broken return value
authorJoe Perches <joe@perches.com>
Tue, 24 Mar 2015 01:01:35 +0000 (18:01 -0700)
committerZefan Li <lizefan@huawei.com>
Fri, 19 Jun 2015 03:40:29 +0000 (11:40 +0800)
commit 6436a123a147db51a0b06024a8350f4c230e73ff upstream.

Return a negative error value like the rest of the entries in this function.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
[PM: tweaked subject line]
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
security/selinux/selinuxfs.c

index 0a9891e7ba94eeb1c20628ed6c1153ffe8f2c216..3bf90453d7948513f410bc55c178ae4f833026dd 100644 (file)
@@ -150,7 +150,7 @@ static ssize_t sel_write_enforce(struct file *file, const char __user *buf,
                goto out;
 
        /* No partial writes. */
-       length = EINVAL;
+       length = -EINVAL;
        if (*ppos != 0)
                goto out;