s4:kdc: Assign RID and attribute together

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index b408e2e8efe9feb233f82273e71a61dc36c40a62..772118db9fe7f15dc77a39ffe92b912e2e2d2496 100644 (file)
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -1784,8 +1784,10 @@ static krb5_error_code samba_kdc_add_domain_group_sid(struct PAC_DEVICE_INFO *in
 
        domain_group->groups.rids = rids;
 
-       domain_group->groups.rids[domain_group->groups.count].rid = rid;
-       domain_group->groups.rids[domain_group->groups.count].attributes = sid->attributes;
+       domain_group->groups.rids[domain_group->groups.count] = (struct samr_RidWithAttribute) {
+               .rid = rid,
+               .attributes = sid->attributes,
+       };
 
        ++domain_group->groups.count;