Make bug chart filenames other-OS friendly by removing colons. Bug 88179. r=jake.

diff --git a/reports.cgi b/reports.cgi
index 163f583c8acb42a8ca9f1af18c7f53d8dca0f4a9..c76a411f79e96ac1cbd7468ba5fad97a7d2b64ab 100755 (executable)
--- a/reports.cgi
+++ b/reports.cgi
@@ -525,23 +525,13 @@ sub chart_image_type {
 sub chart_image_name {
     my ($data_file, $type) = @_;
 
-    my $id = datasets_id($FORM{datasets});
-    my $doy = day_of_year();
+    # Cache charts by generating a unique filename based on what they
+    # show. Charts should be deleted by collectstats.pl nightly.
+    my $id = join ("_", split (":", $FORM{datasets}));
 
     return "${data_file}_${id}.$type";
 }
 
-# Cache charts by generating a unique filename based on what they
-# show. Charts should be deleted by collectstats.pl nightly.
-sub datasets_id {
-       # Current method is very long filenames...      
-       my $longname = "";
-    foreach (@_) {
-         $longname .= $_;
-       }       
-    return $longname;
-}
-
 sub day_of_year {
     my ($mday, $month, $year) = (localtime())[3 .. 5];
     $month += 1;