]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: crystalcove: set IRQCHIP_SKIP_SET_WAKE for the irqchip
authorAaron Lu <aaron.lu@intel.com>
Thu, 28 May 2015 02:58:49 +0000 (10:58 +0800)
committerSasha Levin <sasha.levin@oracle.com>
Sat, 4 Jul 2015 03:02:23 +0000 (23:02 -0400)
[ Upstream commit 61e749d7e1627d375156553ea0ae83c4f6bb5a9b ]

The CrystalCove GPIO irqchip doesn't have irq_set_wake callback defined
so we should set IRQCHIP_SKIP_SET_WAKE for it or it would cause an irq
desc's wake_depth unbalanced warning during system resume phase from the
gpio_keys driver, which is the driver for the power button of the ASUS
T100 laptop.

Signed-off-by: Aaron Lu <aaron.lu@intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/gpio/gpio-crystalcove.c

index a7cf0c193ba8c7d3c5abb23beadc7591c5d5f4cd..2a8791cc138a017146497f32e80e507f37637c6e 100644 (file)
@@ -250,6 +250,7 @@ static struct irq_chip crystalcove_irqchip = {
        .irq_set_type           = crystalcove_irq_type,
        .irq_bus_lock           = crystalcove_bus_lock,
        .irq_bus_sync_unlock    = crystalcove_bus_sync_unlock,
+       .flags                  = IRQCHIP_SKIP_SET_WAKE,
 };
 
 static irqreturn_t crystalcove_gpio_irq_handler(int irq, void *data)