]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip: Use IS_ERR_OR_NULL() instead of NULL and IS_ERR() checks
authorPhilipp Hahn <phahn-oss@avm.de>
Tue, 10 Mar 2026 11:49:05 +0000 (12:49 +0100)
committerThomas Gleixner <tglx@kernel.org>
Tue, 10 Mar 2026 17:34:52 +0000 (18:34 +0100)
Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a open coded NULL
pointer check.

Change generated with coccinelle.

To: Marc Zyngier <maz@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
To: Gregory Clement <gregory.clement@bootlin.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

Signed-off-by: Philipp Hahn <phahn-oss@avm.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260310-b4-is_err_or_null-v1-39-bd63b656022d@avm.de
drivers/irqchip/irq-gic-v3.c
drivers/irqchip/irq-mvebu-odmi.c

index 20f13b686ab22faf722dd2b24faf96af636a4bbd..6dc9827357a21ae05dd838fb717871c73f3c7562 100644 (file)
@@ -2252,7 +2252,7 @@ static int __init gic_of_init(struct device_node *node, struct device_node *pare
 
 out_unmap_rdist:
        for (i = 0; i < nr_redist_regions; i++)
-               if (rdist_regs[i].redist_base && !IS_ERR(rdist_regs[i].redist_base))
+               if (!IS_ERR_OR_NULL(rdist_regs[i].redist_base))
                        iounmap(rdist_regs[i].redist_base);
        kfree(rdist_regs);
 out_unmap_dist:
index b99ab9dcc14b3ba982876cf5525499d02bc1c997..94e7eda46e81833cfe0479b6fabba715bf4ef6b8 100644 (file)
@@ -217,7 +217,7 @@ err_unmap:
        for (i = 0; i < odmis_count; i++) {
                struct odmi_data *odmi = &odmis[i];
 
-               if (odmi->base && !IS_ERR(odmi->base))
+               if (!IS_ERR_OR_NULL(odmi->base))
                        iounmap(odmis[i].base);
        }
        bitmap_free(odmis_bm);