]> git.ipfire.org Git - thirdparty/coreutils.git/commitdiff
add a FIXME comment
authorJim Meyering <jim@meyering.net>
Thu, 26 Sep 2002 08:25:44 +0000 (08:25 +0000)
committerJim Meyering <jim@meyering.net>
Thu, 26 Sep 2002 08:25:44 +0000 (08:25 +0000)
src/csplit.c

index df8546d7a4c3b60bb9a29d4ab56aecfd636e6125..2ee32a3e6f9469c59a1a240f6897c55bc3590904 100644 (file)
@@ -1249,6 +1249,9 @@ get_format_width (char **format_ptr)
      allow for enough octal digits to represent the value of LONG_MAX.  */
   count = ((*format_ptr == start)
           ? bytes_to_octal_digits[sizeof (long)]
+          /* FIXME: don't use atoi, it may silently overflow.
+             Besides, we know the result is non-negative, so shouldn't
+             need that cast.  */
           : (unsigned) atoi (start));
   **format_ptr = ch_save;
   return count;