]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 747110: Fix race condition in showdependencygraph.cgi triggering "use of uninitia...
authorByron Jones <bjones@mozilla.com>
Mon, 23 Apr 2012 08:54:16 +0000 (16:54 +0800)
committerByron Jones <bjones@mozilla.com>
Mon, 23 Apr 2012 08:54:16 +0000 (16:54 +0800)
r=LpSolit, a=LpSolit

showdependencygraph.cgi

index de6caa4592ea690b49c39516effd6b4660bec244..32abf1747f5f190bce8fdf34ae7326255576f481 100755 (executable)
@@ -296,7 +296,8 @@ foreach my $f (@files)
     # symlinks), this can't escape to delete anything it shouldn't
     # (unless someone moves the location of $webdotdir, of course)
     trick_taint($f);
-    if (file_mod_time($f) < $since) {
+    my $mtime = file_mod_time($f);
+    if ($mtime && $mtime < $since) {
         unlink $f;
     }
 }