]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: qcom: camcc-sm6350: Specify Titan GDSC power domain as a parent to other
authorVladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Tue, 21 Oct 2025 23:44:46 +0000 (02:44 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Dec 2025 12:54:46 +0000 (13:54 +0100)
[ Upstream commit a76ce61d7225934b0a52c8172a8cd944002a8c6f ]

When a consumer turns on/off a power domain dependent on another power
domain in hardware, the parent power domain shall be turned on/off by
the power domain provider as well, and to get it the power domain hardware
hierarchy shall be described in the CAMCC driver.

Establish the power domain hierarchy with a Titan GDSC set as a parent of
all other GDSC power domains provided by the SM6350 camera clock controller
to enforce a correct sequence of enabling and disabling power domains by
the consumers, this fixes the CAMCC as a supplier of power domains to CAMSS
IP and its driver.

Fixes: 80f5451d9a7c ("clk: qcom: Add camera clock controller driver for SM6350")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Link: https://lore.kernel.org/r/20251021234450.2271279-3-vladimir.zapolskiy@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/qcom/camcc-sm6350.c

index 418668184ec355140a380d60aaaaba1b2c898435..454763425f611ca25cdeba96ec3eaa305bdcdc0f 100644 (file)
@@ -1692,6 +1692,8 @@ static struct clk_branch camcc_sys_tmr_clk = {
        },
 };
 
+static struct gdsc titan_top_gdsc;
+
 static struct gdsc bps_gdsc = {
        .gdscr = 0x6004,
        .en_rest_wait_val = 0x2,
@@ -1701,6 +1703,7 @@ static struct gdsc bps_gdsc = {
                .name = "bps_gdsc",
        },
        .pwrsts = PWRSTS_OFF_ON,
+       .parent = &titan_top_gdsc.pd,
        .flags = VOTABLE,
 };
 
@@ -1713,6 +1716,7 @@ static struct gdsc ipe_0_gdsc = {
                .name = "ipe_0_gdsc",
        },
        .pwrsts = PWRSTS_OFF_ON,
+       .parent = &titan_top_gdsc.pd,
        .flags = VOTABLE,
 };
 
@@ -1725,6 +1729,7 @@ static struct gdsc ife_0_gdsc = {
                .name = "ife_0_gdsc",
        },
        .pwrsts = PWRSTS_OFF_ON,
+       .parent = &titan_top_gdsc.pd,
 };
 
 static struct gdsc ife_1_gdsc = {
@@ -1736,6 +1741,7 @@ static struct gdsc ife_1_gdsc = {
                .name = "ife_1_gdsc",
        },
        .pwrsts = PWRSTS_OFF_ON,
+       .parent = &titan_top_gdsc.pd,
 };
 
 static struct gdsc ife_2_gdsc = {
@@ -1747,6 +1753,7 @@ static struct gdsc ife_2_gdsc = {
                .name = "ife_2_gdsc",
        },
        .pwrsts = PWRSTS_OFF_ON,
+       .parent = &titan_top_gdsc.pd,
 };
 
 static struct gdsc titan_top_gdsc = {