Bug 670128: Missing explicit exit after calls to $cgi->redirect(), making the rest...

r=dkl a=LpSolit

diff --git a/post_bug.cgi b/post_bug.cgi
index e6b77f8eafce89e20a1787a8068ccd3148f6e71a..6d6ed746ca0de692a048cdb021b7c4d8737153f1 100755 (executable)
--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -55,7 +55,10 @@ my $vars = {};
 ######################################################################
 
 # redirect to enter_bug if no field is passed.
-print $cgi->redirect(correct_urlbase() . 'enter_bug.cgi') unless $cgi->param();
+unless ($cgi->param()) {
+    print $cgi->redirect(correct_urlbase() . 'enter_bug.cgi');
+    exit;
+}
 
 # Detect if the user already used the same form to submit a bug
 my $token = trim($cgi->param('token'));

diff --git a/relogin.cgi b/relogin.cgi
index 028f4ddb11426f6c736300f972acd3a92e2acdd2..f6a410c050574f42e7a3ef42f71ab882c628aff9 100755 (executable)
--- a/relogin.cgi
+++ b/relogin.cgi
@@ -45,6 +45,7 @@ my $target;
 if (!$action) {
     # redirect to index.cgi if no action is defined.
     print $cgi->redirect(correct_urlbase() . 'index.cgi');
+    exit;
 }
 # prepare-sudo: Display the sudo information & login page
 elsif ($action eq 'prepare-sudo') {