]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: capabilities: Always assume QEMU_CAPS_BLOCKJOB_ASYNC
authorPeter Krempa <pkrempa@redhat.com>
Tue, 5 Jun 2018 11:42:44 +0000 (13:42 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 3 Apr 2019 09:58:09 +0000 (11:58 +0200)
This was detected by the presence of 'block-stream' which is present in
qemu since v1.1 (db58f9c0605fa151b8c4)

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
40 files changed:
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h
src/qemu/qemu_domain.c
src/qemu/qemu_driver.c
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml
tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml
tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml
tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml
tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml
tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml
tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml
tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml
tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml
tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml
tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml

index b55274955ecc89afcbb227acc05eeb2469f5bd8e..6e83922b383c1907fc52a9940f59233cc5896cc3 100644 (file)
@@ -959,7 +959,6 @@ struct virQEMUCapsStringFlags {
 
 struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
     { "transaction", QEMU_CAPS_TRANSACTION },
-    { "block-stream", QEMU_CAPS_BLOCKJOB_ASYNC },
     { "dump-guest-memory", QEMU_CAPS_DUMP_GUEST_MEMORY },
     { "query-spice", QEMU_CAPS_SPICE },
     { "block-commit", QEMU_CAPS_BLOCK_COMMIT },
index 06c7606e2f2deaaf8abb847452cfa987494b4444..0087ccb294fa1578b63309a5194cbe4f4580b61f 100644 (file)
@@ -173,7 +173,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
 
     /* 90 */
     X_QEMU_CAPS_BLOCKJOB_SYNC, /* old block_job_cancel, block_stream */
-    QEMU_CAPS_BLOCKJOB_ASYNC, /* new block-job-cancel, block-stream */
+    X_QEMU_CAPS_BLOCKJOB_ASYNC, /* new block-job-cancel, block-stream */
     X_QEMU_CAPS_SCSI_CD, /* -device scsi-cd */
     X_QEMU_CAPS_IDE_CD, /* -device ide-cd */
     X_QEMU_CAPS_NO_USER_CONFIG, /* -no-user-config */
index 5f55aa573d592cdd3b807c39491845c8f43454c3..f2cf3f580deeb8f80ebc252907549dbcd53e21f4 100644 (file)
@@ -9863,17 +9863,8 @@ qemuDomainGetMonitor(virDomainObjPtr vm)
  * returns 0.
  */
 int
-qemuDomainSupportsBlockJobs(virDomainObjPtr vm)
+qemuDomainSupportsBlockJobs(virDomainObjPtr vm ATTRIBUTE_UNUSED)
 {
-    qemuDomainObjPrivatePtr priv = vm->privateData;
-    bool asynchronous = virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC);
-
-    if (!asynchronous) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("block jobs not supported with this QEMU binary"));
-        return -1;
-    }
-
     return 0;
 }
 
index 62d8d977c5413532182125b673c897dc03977ff9..e1e04beacb289b0d407fcde1de676baf68d07f3a 100644 (file)
@@ -17695,8 +17695,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm,
         qemuDomainDefValidateDiskLunSource(mirror) < 0)
         goto endjob;
 
-    if (!(virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DRIVE_MIRROR) &&
-          virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC))) {
+    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DRIVE_MIRROR)) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("block copy is not supported with this QEMU binary"));
         goto endjob;
@@ -18078,10 +18077,8 @@ qemuDomainBlockCommit(virDomainPtr dom,
 
     if (virDomainObjCheckActive(vm) < 0)
         goto endjob;
-    /* Ensure that no one backports commit to RHEL 6.2, where cancel
-     * behaved differently */
-    if (!(virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCK_COMMIT) &&
-          virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKJOB_ASYNC))) {
+
+    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCK_COMMIT)) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("online commit not supported with this QEMU binary"));
         goto endjob;
index d6269102589f998b92f2e351704ca665b20c21f2..a4028d156d6146a8121f3360eca2151a6fb2f35e 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index c281cd5f7fcc3d61f4f095ae9d010c33303b934c..8772b7d3bec9428a8a95836428144b5dc54850d2 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index bb6c598fc2b6a4dddc3e2b46ffc27af8b1c56215..68f015e66f2bd260a9aed893408e6a0031a0836a 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 340a725287cc8764b57df04857cdd64de4cacf8f..a6cc1cb35049e9bea96710816e03a96bffcb0b29 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index e8bf3cef9f66c74f73dfbac6831dc518573d3bf2..84ae8ebdeb42433a5aefd1f4e3a68f0cb22e884a 100644 (file)
@@ -21,7 +21,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index b24e26dfc522192d40c2bc29aabde8f87e5fff43..babc25b205373c3c5091742d53d27a99b176e9e6 100644 (file)
@@ -20,7 +20,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 6707633b14f160428f10b7256c7e6d9cc1309fa7..a7debf552fbe9309428cc5ae6ed8a9be0ea1ea76 100644 (file)
@@ -11,7 +11,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='blockio'/>
index 1e3a4d753c10a92edd778d0205f6787bf1907cb8..97d3d9f84bc63e5c4dc9a003356b55b8d76223c3 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index a781af8a04ee1214bfaa46bcbb375d49d83e5c4a..b89e956aef4a6466c782c8788611923d96fbba89 100644 (file)
@@ -11,7 +11,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='blockio'/>
index 1ebf54baaee2e90379d1fb43efa0e5b72ba73437..bf05fa7875124a0c1fa1ded2929ef8b82f2163ef 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 4531964c751e73b959a9da0638becb00da4f8429..f4618105a1557ef28c26cc1e0c38857c9c5e51f4 100644 (file)
@@ -21,7 +21,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 835d36425fabc2d29d56fd8d139c6f619af21dfa..e35d3d09cfa057bc1036635c4cb613b72f17b01d 100644 (file)
@@ -20,7 +20,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 4988ab3fe7b979325482dcff95bf557b27180511..9b89c3de4c2d47a1237c6250968ce4ed621ccc2e 100644 (file)
@@ -11,7 +11,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='blockio'/>
index 301ab899bbe6c56f161bef160127c3f47fc8e18b..88c47fca1c99dc61bcde8e707785812e1583e463 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 14de9d7b3b6413a3b9f152d08078ab35740eb9e3..fc4181fb0a086be836aa714af0f1b2f7f7db6e0a 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 24f47515d48d5c061de3f2a00ea348d2463bffa9..094968cd22712ef0324d74f56d486bf145aa15b6 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 59688ea09f459ec9827ee22cd421bd3bb1cbd854..ef9ca191648358a52f8383a5761b40cb68925dfd 100644 (file)
@@ -23,7 +23,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 0ceadb42c02d0c1b239ab17c72b06347036c2692..3370d187b508fa574f2b7640c8fc52aa8fdee85e 100644 (file)
@@ -20,7 +20,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 828ee630afc9061dc55adb02b01292acff37191f..290800fe6552d4f6a99d8273875631eb4495ffda 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 77e067e9ba68f893ee06da4094ef758320624192..dc156b7ef5683d1a6118225b46c196ba22727324 100644 (file)
@@ -11,7 +11,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='blockio'/>
index 9e9aeb144986b9584d5bb40968384d43358734da..5deba03200e35a0bfc7ed36710284a4401888978 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 87cc501e25b11d7beb519e8977c3c6fdaa5f8f5c..e153c3294dabefcaf12fca81cfb2cdbdbba49d09 100644 (file)
@@ -11,7 +11,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='blockio'/>
index 5eb786945b81e01a56bbe38423b7506aa9c0c4c3..f21df7f7b048a416e4b795ecbc38271eee5654a3 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 0bc61f9c2b21674d32bbb182fabb4610221ea477..198ae8cd40f0d8fa0156b58292bf1cda41a918f9 100644 (file)
@@ -20,7 +20,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index f628417a0dd06d97f6a3f2ec8ec4c1d117dd97af..f8902013b599e1fa51688ef62bf84af703c759c5 100644 (file)
@@ -11,7 +11,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='blockio'/>
index fe3385680a51a6c758bc9d976f99a54c3e08038d..0f0d6551f4b61ae8c9fa265ecaafb6223d685331 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 4de8f17f517a22de64950826831ea2970c350da5..805e1af9baf807411a240dc1894b265553c045d3 100644 (file)
@@ -20,7 +20,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 669c0dd786ba5dc14d0b5db1dd8308099c34f6ea..978bec6172af523a852676ca30731e301c7bd472 100644 (file)
@@ -5,7 +5,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='scsi-disk.wwn'/>
index 7884d6c07fdbb3ef0fa075f7ef0726081726cf86..d39cb5e556444ba327437c00399c6bab198cb52a 100644 (file)
@@ -5,7 +5,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='scsi-disk.wwn'/>
index 57d9fc677040927afe2978ed1d66d25dc9283487..9ee63263da92d2704f45def41650eb8e6d435377 100644 (file)
@@ -12,7 +12,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='dump-guest-memory'/>
   <flag name='virtio-scsi-pci'/>
   <flag name='blockio'/>
index ad942520e9541cedab5c727328040c06aabfd0a2..79d31dca65f1745073cac3096c2e51a6e76124c8 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 1ad1dbcdbcf85dfd03750cbadfa2b50a1ac6ac9a..848e9099f96aebb5680dc9f21c546c7713cb84a8 100644 (file)
@@ -20,7 +20,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 39b910e3b18e2656079ae468000e66b6a189bc9b..930e71e117b09c079a88130130e45283930cb89c 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index 396e3019a0de7d15e5a12fad0aa2c7beb8801344..580b895e984a5cf142db0b27c98ed3a8df502b35 100644 (file)
@@ -23,7 +23,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index addc6ae4d3da8eb2f431f491595607b1f1efd4a4..5b2979d284a6a54700b5e3d83fac50cd403b69cf 100644 (file)
@@ -23,7 +23,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>
index fcfc451595663fd643bec7493feeef2bb154adfe..b2309d6953f52448381ef1b85bf2590382aa2b90 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='scsi-disk.channel'/>
   <flag name='scsi-block'/>
   <flag name='transaction'/>
-  <flag name='block-job-async'/>
   <flag name='hda-micro'/>
   <flag name='dump-guest-memory'/>
   <flag name='nec-usb-xhci'/>