FIX: Remove disks in mdmon for external metadata

For raid10 -> raid0 takeover operation we should reject disks
in mirror by marking them as 'failed' and then remove them from
array by writing "remove" to disk state.

For external metadata second action is executed by mdmon.
According the description in monitor.c:175 when monitor detect
"faulty" in device state, it blocks the device, mark it as failed
in metadata, unblocks the device and finally writes "remove"
to device state.
For external case writing "remove" to device state in mdadm
is not necessary and harmful.
It may cause following issues:
1. "remove" operation for external case in mdadm is not finish
with successful result because monitor may block the device or disk
has been already removed by monitor.
2. If disk is removed by mdadm earlier than mdmon catch "failed" state,
metadata is not properly updated- is not marked as failed.

Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>

diff --git a/Grow.c b/Grow.c
index d7deb0f5fb76cd085b59004d02d94e7c3b32c590..21189010dc78c2cb48b606be7bd1463f851a7129 100644 (file)
--- a/Grow.c
+++ b/Grow.c
@@ -719,7 +719,9 @@ int remove_disks_for_takeover(struct supertype *st,
 
                sysfs_set_str(sra, sd, "state", "faulty");
                sysfs_set_str(sra, sd, "slot", "none");
-               sysfs_set_str(sra, sd, "state", "remove");
+               /* for external metadata disks should be removed in mdmon */
+               if (!st->ss->external)
+                       sysfs_set_str(sra, sd, "state", "remove");
                sd->disk.state |= (1<<MD_DISK_REMOVED);
                sd->disk.state &= ~(1<<MD_DISK_SYNC);
                sd->next = sra->devs;