]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
auth/kerberos: Check memory allocation in gssapi_get_session_key()
authorPavel Filipenský <pfilipensky@samba.org>
Thu, 4 Dec 2025 12:02:19 +0000 (13:02 +0100)
committerPavel Filipensky <pfilipensky@samba.org>
Tue, 13 Jan 2026 11:31:35 +0000 (11:31 +0000)
Signed-off-by: Pavel Filipenský <pfilipensky@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
auth/kerberos/gssapi_pac.c

index 723949923dc361b7bf1c2cc28f55b495ad59079a..19102946dc6b79a51687f256e94e5212629777f9 100644 (file)
@@ -228,6 +228,9 @@ NTSTATUS gssapi_get_session_key(TALLOC_CTX *mem_ctx,
                if (session_key) {
                        *session_key = data_blob_talloc(mem_ctx,
                                                        KRB5_KEY_DATA(subkey), KRB5_KEY_LENGTH(subkey));
+                       if (session_key->data == NULL) {
+                               return NT_STATUS_NO_MEMORY;
+                       }
                }
                if (keytype) {
                        *keytype = KRB5_KEY_TYPE(subkey);
@@ -243,6 +246,9 @@ NTSTATUS gssapi_get_session_key(TALLOC_CTX *mem_ctx,
        if (session_key) {
                *session_key = data_blob_talloc(mem_ctx, set->elements[0].value,
                                                set->elements[0].length);
+               if (session_key->data == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
        }
 
        if (keytype) {