]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/rockchip: rgb: remove now-redundant call to drm_connector_attach_encoder()
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Thu, 23 Apr 2026 11:55:49 +0000 (13:55 +0200)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Thu, 30 Apr 2026 09:15:46 +0000 (11:15 +0200)
drm_connector_attach_encoder() is now called by
drm_bridge_connector_init().

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20260423115550.444930-6-luca.ceresoli@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/rockchip/rockchip_rgb.c

index 5c0c6e2cc28dc9634d46d8309c5a52361203a991..add3123e5ce70e9fdb1bb8dc9ea28e4e4358ab56 100644 (file)
@@ -162,17 +162,8 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev,
 
        rgb->encoder.crtc_endpoint_id = endpoint_id;
 
-       ret = drm_connector_attach_encoder(connector, encoder);
-       if (ret < 0) {
-               DRM_DEV_ERROR(drm_dev->dev,
-                             "failed to attach encoder: %d\n", ret);
-               goto err_free_connector;
-       }
-
        return rgb;
 
-err_free_connector:
-       drm_connector_cleanup(connector);
 err_free_encoder:
        drm_encoder_cleanup(encoder);
        return ERR_PTR(ret);