[ng] maintcheck: fix real and spurious warnings

This failures have been introduced by the recent merging of
master.

* lib/am/check.am: Don't use '$(AM_MAKEFLAGS)' in recursive make
invocations.
* tests/make-dryrun.test: Likewise.  Also, avoid code to determine
whether $MAKE is GNU make or supports the required make features:
we can assume that unconditionally.
* lib/am/header-vars.am: Remove references to NetBSD and Solaris
make from the comments.

diff --git a/lib/am/check.am b/lib/am/check.am
index 9cb3b76a41d2c2eabf9686ca3bd50e9b295781cf..8df0c6a3c345fec7a6d7b838be6ef3f88c10d07e 100644 (file)
--- a/lib/am/check.am
+++ b/lib/am/check.am
@@ -161,7 +161,7 @@ $(TEST_SUITE_LOG): $(TEST_LOGS)
          echo "fatal: making $(TEST_SUITE_LOG): possible infinite" \
               "recursion detected" >&2; \
        else \
-         am__remaking_logs=yes $(MAKE) $(AM_MAKEFLAGS) $$redo_logs; \
+         am__remaking_logs=yes $(MAKE) $$redo_logs; \
        fi; \
        if $(am__make_dryrun); then :; else \
 ## Sanity check: each unreadable or non-existent test result file should

diff --git a/lib/am/header-vars.am b/lib/am/header-vars.am
index 6662dc6298f1001c7d8f14bf112e74a006a15a24..1bfc5aef754570251ce2bec4a21553c59751c292 100644 (file)
--- a/lib/am/header-vars.am
+++ b/lib/am/header-vars.am
@@ -31,10 +31,9 @@ am__vpath_rewrite = \
 ## DESTDIR =
 
 ## Shell code that determines whether make is running in "dry mode"
-## ("make -n") or not.  Useful in rules that invoke make recursively,
-## and are thus executed also with "make -n" -- either because they
-## are declared as dependencies to '.MAKE' (NetBSD make), or because
-## their recipes contain the "$(MAKE)" string (GNU and Solari make).
+## ("make -n") or not.  Useful in rules that invoke make recursively, and
+## are thus executed also with "make -n" -- because, say, their recipes
+## contain the "$(MAKE)" string or starts with the '+' modifier.
 am__make_dryrun = \
   { \
     am__dry=no; \

diff --git a/tests/make-dryrun.test b/tests/make-dryrun.test
index 0202dc90909717aa7333a04e8bd23ef4f460610b..ade314f96b1682c72371b023017c62104227de87 100755 (executable)
--- a/tests/make-dryrun.test
+++ b/tests/make-dryrun.test
@@ -46,20 +46,16 @@ $MAKE notdry
 # heinous, since make running in normal mode was sometimes
 # mistaken for make running in dry mode.
 $MAKE notdry TESTS="n1.test n2.test"
-$MAKE notdry TESTS="n1 n2" AM_MAKEFLAGS="TESTS='n1 n2'"
-$MAKE notdry TESTS="n1 n2" AM_MAKEFLAGS='TESTS="n1 n2"'
+$MAKE notdry TESTS="n1 n2"
+$MAKE notdry TESTS="n1 n2"
 $MAKE notdry FOOFLAGS="-n -n -knf2 \\n --none -n"
 $MAKE notdry BARFLAGS="-n \"n\" '-n' --none -n"
 
-if echo 'all: ; @+printf %sbb%s aa cc' | $MAKE -n -f - | grep aabbcc; then
-  $MAKE -n dry
-  test -f from-dry-mode
-  rm -f from-dry-mode
-fi
+$MAKE -n dry
+test -f from-dry-mode
+rm -f from-dry-mode
 
-if using_gmake; then
-  $MAKE --dry-run -k dry
-  test -f from-dry-mode
-fi
+$MAKE --dry-run -k dry
+test -f from-dry-mode
 
 :