]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: tests: fix return 0 on rmap test failure
authorNaohiro Aota <naohiro.aota@wdc.com>
Mon, 5 Jan 2026 08:19:05 +0000 (17:19 +0900)
committerDavid Sterba <dsterba@suse.com>
Fri, 9 Jan 2026 16:41:48 +0000 (17:41 +0100)
In test_rmap_blocks(), we have ret = 0 before checking the results. We need
to set it to -EINVAL, so that a mismatching result will return -EINVAL not
0.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tests/extent-map-tests.c

index 0b9f25dd1a68a6914cd2792ada5f7def9094bb6a..aabf825e8d7bccc5896338812a2cd4fd37f75536 100644 (file)
@@ -1059,6 +1059,7 @@ static int test_rmap_block(struct btrfs_fs_info *fs_info,
 
        if (out_stripe_len != BTRFS_STRIPE_LEN) {
                test_err("calculated stripe length doesn't match");
+               ret = -EINVAL;
                goto out;
        }
 
@@ -1066,12 +1067,14 @@ static int test_rmap_block(struct btrfs_fs_info *fs_info,
                for (i = 0; i < out_ndaddrs; i++)
                        test_msg("mapped %llu", logical[i]);
                test_err("unexpected number of mapped addresses: %d", out_ndaddrs);
+               ret = -EINVAL;
                goto out;
        }
 
        for (i = 0; i < out_ndaddrs; i++) {
                if (logical[i] != test->mapped_logical[i]) {
                        test_err("unexpected logical address mapped");
+                       ret = -EINVAL;
                        goto out;
                }
        }