refclock_oncore.c:

  mem leakage: free old malloced buffer on errors (Coverity CID 2056 NetBSD Scan 5)

bk: 441c147bwYBxtgAq_KwKWqNdmm5VMg

diff --git a/ntpd/refclock_oncore.c b/ntpd/refclock_oncore.c
index fe64d98ec326d54069d9e4d9ec3276b4bdfb2341..087427020f2d6ac3aad45a9f91642bcba872e7a3 100644 (file)
--- a/ntpd/refclock_oncore.c
+++ b/ntpd/refclock_oncore.c
@@ -936,6 +936,9 @@ oncore_init_shmem(
 
        if ((instance->shmemfd = open(instance->shmem_fname, O_RDWR|O_CREAT|O_TRUNC, 0644)) < 0) {
                record_clock_stats(&(instance->peer->srcadr), "ONCORE: Can't open shmem");
+               if (shmem_old)
+                       free(shmem_old);
+
                return;
        }
 
@@ -969,6 +972,9 @@ oncore_init_shmem(
        if (buf == NULL) {
                record_clock_stats(&(instance->peer->srcadr), "ONCORE: Can't malloc buffer for shmem");
                close(instance->shmemfd);
+               if (shmem_old)
+                       free(shmem_old);
+
                return;
        }