]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
tests: Remove disk from 'serial-unix-chardev' test
authorPeter Krempa <pkrempa@redhat.com>
Mon, 9 Jul 2018 10:05:56 +0000 (12:05 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 10 Jul 2018 11:32:53 +0000 (13:32 +0200)
We are testing character devices so the disk is not necessary. Minimize
the configuration. This will prevent changes when switching to blockdev.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tests/qemuxml2argvdata/serial-unix-chardev.args
tests/qemuxml2argvdata/serial-unix-chardev.x86_64-latest.args
tests/qemuxml2argvdata/serial-unix-chardev.xml

index 873d3263c63b66a0d11548a5e1e42b12ae5cc781..1977ba5cd73e454e78a430ee396562539b537fda 100644 (file)
@@ -22,8 +22,6 @@ server,nowait \
 -no-acpi \
 -boot c \
 -usb \
--drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \
--device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
 -chardev socket,id=charserial0,path=/tmp/serial.sock \
 -device isa-serial,chardev=charserial0,id=serial0 \
 -chardev socket,id=charserial1,path=/tmp/serial-server.sock,server,nowait \
index ce7a7f80d7afbb9accfd3d7d127e08e057a25764..e9ce4d31813ae5e7d0016f5659fe7248c9cc229c 100644 (file)
@@ -24,8 +24,6 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \
 -no-acpi \
 -boot strict=on \
 -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 \
--drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \
--device ide-hd,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,bootindex=1 \
 -chardev socket,id=charserial0,path=/tmp/serial.sock \
 -device isa-serial,chardev=charserial0,id=serial0 \
 -chardev socket,id=charserial1,fd=1729,server,nowait \
index af513d64450e4ba0709462b28f3fba34e828e03c..f977d4d25c99a7c0d182942eb372a45e973f1f5b 100644 (file)
   <on_crash>destroy</on_crash>
   <devices>
     <emulator>/usr/bin/qemu-system-i686</emulator>
-    <disk type='block' device='disk'>
-      <source dev='/dev/HostVG/QEMUGuest1'/>
-      <target dev='hda' bus='ide'/>
-      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
-    </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
     <serial type='unix'>