]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
coresight: Don't reject unrecognized ETMv3 format attributes
authorJames Clark <james.clark@linaro.org>
Fri, 28 Nov 2025 11:55:19 +0000 (11:55 +0000)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Mon, 22 Dec 2025 15:30:53 +0000 (15:30 +0000)
config isn't the only field, there are also config1, config2, etc.
Rejecting unrecognized attributes is therefore inconsistent as it wasn't
done for all fields. It was only necessary when we were directly
programming attr->config into ETMCR and didn't hide the unsupported
fields, but now it's not needed so remove it.

Reviewed-by: Leo Yan <leo.yan@arm.com>
Reviewed-by: Mike Leach <mike.leach@linaro.org>
Tested-by: Leo Yan <leo.yan@arm.com>
Signed-off-by: James Clark <james.clark@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20251128-james-cs-syncfreq-v8-7-4d319764cc58@linaro.org
drivers/hwtracing/coresight/coresight-etm3x-core.c

index 4511fc2f8d727f94edd85e2ead9402b01559a856..584d653eda8166361bbf275b2de82149b3def27f 100644 (file)
@@ -333,13 +333,6 @@ static int etm_parse_event_config(struct etm_drvdata *drvdata,
        if (config->mode)
                etm_config_trace_mode(config);
 
-       /*
-        * At this time only cycle accurate, return stack  and timestamp
-        * options are available.
-        */
-       if (attr->config & ~ETM3X_SUPPORTED_OPTIONS)
-               return -EINVAL;
-
        config->ctrl = 0;
 
        if (ATTR_CFG_GET_FLD(attr, cycacc))