]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
crypto: qce - remove unneeded call to icc_set_bw() in error path
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 3 Dec 2024 09:19:31 +0000 (10:19 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 14 Dec 2024 09:21:43 +0000 (17:21 +0800)
There's no need to call icc_set_bw(qce->mem_path, 0, 0); in error path
as this will already be done in the release path of devm_of_icc_get().

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/qce/core.c

index 848e5e802b92b91a901c0fb108c81ce297a46fe4..f9ff1dfc1defefd830295779afa8090d33738876 100644 (file)
@@ -234,7 +234,7 @@ static int qce_crypto_probe(struct platform_device *pdev)
 
        ret = clk_prepare_enable(qce->core);
        if (ret)
-               goto err_mem_path_disable;
+               return ret;
 
        ret = clk_prepare_enable(qce->iface);
        if (ret)
@@ -274,8 +274,6 @@ err_clks_iface:
        clk_disable_unprepare(qce->iface);
 err_clks_core:
        clk_disable_unprepare(qce->core);
-err_mem_path_disable:
-       icc_set_bw(qce->mem_path, 0, 0);
 
        return ret;
 }