]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ubsan: Remove regs from report_ubsan_failure()
authorMostafa Saleh <smostafa@google.com>
Wed, 30 Apr 2025 16:27:09 +0000 (16:27 +0000)
committerMarc Zyngier <maz@kernel.org>
Wed, 7 May 2025 10:21:35 +0000 (11:21 +0100)
report_ubsan_failure() doesn't use argument regs, and soon it will
be called from the hypervisor context were regs are not available.
So, remove the unused argument.

Signed-off-by: Mostafa Saleh <smostafa@google.com>
Acked-by: Kees Cook <kees@kernel.org>
Link: https://lore.kernel.org/r/20250430162713.1997569-3-smostafa@google.com
Signed-off-by: Marc Zyngier <maz@kernel.org>
arch/arm64/kernel/traps.c
arch/x86/kernel/traps.c
include/linux/ubsan.h
lib/ubsan.c

index 224f927ac8afb7f94b4804433ad30728169c474c..9bfa5c944379d3f196231a3e6b13111c497872bd 100644 (file)
@@ -1118,7 +1118,7 @@ static struct break_hook kasan_break_hook = {
 #ifdef CONFIG_UBSAN_TRAP
 static int ubsan_handler(struct pt_regs *regs, unsigned long esr)
 {
-       die(report_ubsan_failure(regs, esr & UBSAN_BRK_MASK), regs, esr);
+       die(report_ubsan_failure(esr & UBSAN_BRK_MASK), regs, esr);
        return DBG_HOOK_HANDLED;
 }
 
index 9f88b8a78e50912790077cff0f940c7f601aff33..4b5a7a1a8ddee39c30a486510e2b53ab0a5a2917 100644 (file)
@@ -351,7 +351,7 @@ static noinstr bool handle_bug(struct pt_regs *regs)
        case BUG_UD1_UBSAN:
                if (IS_ENABLED(CONFIG_UBSAN_TRAP)) {
                        pr_crit("%s at %pS\n",
-                               report_ubsan_failure(regs, ud_imm),
+                               report_ubsan_failure(ud_imm),
                                (void *)regs->ip);
                }
                break;
index d8219cbe09ff8d4d504bff36b74cf72f44e4a4c1..c843816f5f6827df820a762761d75431d366b8fd 100644 (file)
@@ -3,9 +3,9 @@
 #define _LINUX_UBSAN_H
 
 #ifdef CONFIG_UBSAN_TRAP
-const char *report_ubsan_failure(struct pt_regs *regs, u32 check_type);
+const char *report_ubsan_failure(u32 check_type);
 #else
-static inline const char *report_ubsan_failure(struct pt_regs *regs, u32 check_type)
+static inline const char *report_ubsan_failure(u32 check_type)
 {
        return NULL;
 }
index cdc1d31c3821bdb26ed82c4beec7dbd8f83040ee..17993727fc96e5cecbf16d061cc124b4cc174411 100644 (file)
@@ -25,7 +25,7 @@
  * The mappings of struct SanitizerKind (the -fsanitize=xxx args) to
  * enum SanitizerHandler (the traps) in Clang is in clang/lib/CodeGen/.
  */
-const char *report_ubsan_failure(struct pt_regs *regs, u32 check_type)
+const char *report_ubsan_failure(u32 check_type)
 {
        switch (check_type) {
 #ifdef CONFIG_UBSAN_BOUNDS