]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Drop QEMU_CAPS_VNC_WEBSOCKET
authorAndrea Bolognani <abologna@redhat.com>
Wed, 12 Sep 2018 12:29:13 +0000 (14:29 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 12 Sep 2018 13:35:58 +0000 (15:35 +0200)
The capability was introduced in QEMU 1.3.1 and we require
QEMU 1.5.0 these days.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
34 files changed:
src/qemu/qemu_capabilities.c
src/qemu/qemu_capabilities.h
src/qemu/qemu_command.c
tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml
tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml
tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml
tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml
tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml
tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml
tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml
tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml
tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml
tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml
tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml
tests/qemuxml2argvtest.c

index 308f5602ca87adee27a451025cd83d980cda7f3f..f7753a5ac361fab8bb757cf2f6b64813efff759b 100644 (file)
@@ -4148,10 +4148,6 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
 
     virQEMUCapsInitQMPBasicArch(qemuCaps);
 
-    /* WebSockets were introduced between 1.3.0 and 1.3.1 */
-    if (qemuCaps->version >= 1003001)
-        virQEMUCapsSet(qemuCaps, QEMU_CAPS_VNC_WEBSOCKET);
-
     /* -chardev spiceport is supported from 1.4.0, but usable through
      * qapi only since 1.5.0, however, it still cannot be queried
      * for as a capability */
index 0f69c691367c8b8bcd2faa1ab70b876e68d1e392..fad223eab75825e8be3db0b850d15d003ff4fbd4 100644 (file)
@@ -253,7 +253,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
     /* 145 */
     X_QEMU_CAPS_DEVICE_SCSI_GENERIC_BOOTINDEX, /* -device scsi-generic.bootindex */
     QEMU_CAPS_MEM_MERGE, /* -machine mem-merge */
-    QEMU_CAPS_VNC_WEBSOCKET, /* -vnc x:y,websocket */
+    X_QEMU_CAPS_VNC_WEBSOCKET, /* -vnc x:y,websocket */
     QEMU_CAPS_DRIVE_DISCARD, /* -drive discard=off(ignore)|on(unmap) */
     QEMU_CAPS_REALTIME_MLOCK, /* -realtime mlock=on|off */
 
index ff9589f593a0e46f20d01dc01116470e799b7701..95d79235a42e164e5d5cbdba69603e66f9fd455c 100644 (file)
@@ -7843,15 +7843,8 @@ qemuBuildGraphicsVNCCommandLine(virQEMUDriverConfigPtr cfg,
         virBufferAsprintf(&opt, ":%d",
                           graphics->data.vnc.port - 5900);
 
-        if (graphics->data.vnc.websocket) {
-            if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VNC_WEBSOCKET)) {
-                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                               _("VNC WebSockets are not supported "
-                                 "with this QEMU binary"));
-                goto error;
-            }
+        if (graphics->data.vnc.websocket)
             virBufferAsprintf(&opt, ",websocket=%d", graphics->data.vnc.websocket);
-        }
         break;
 
     case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE:
index b791b138306c984d93689811351b2cc4ee3fa28f..34239f1eccefcda51ac895c5829a94dd80e8134f 100644 (file)
@@ -64,7 +64,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 3a0df4d4178420877c1e0441d43e976944321f99..17b430878e66a55291baa75846b4a1e004e08993 100644 (file)
@@ -65,7 +65,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
   <flag name='dmi-to-pci-bridge'/>
index dede48d65f50cb489b5099460631d9fcdc0a0110..8d0bad6225ccadb2fba9fdfd9951ff988c66c9d0 100644 (file)
@@ -65,7 +65,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 05badb66754ce2370aa172847fce4a7834653ba4..e2d3e3f55b443c20c37cde9ccdc1e75a0909eae0 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index d1224410f6c4e31cf522ba4b48459ddcdc1d5574..73a9c46ddefc5b535e8085ef0b9ead8c175c129d 100644 (file)
@@ -53,7 +53,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 8eac816b3a91a331fde9d5fbba4b290387c47e6d..2c9045ce2feebf5b7b07fbb9b128002a7cc3cc75 100644 (file)
@@ -53,7 +53,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index a8cd1fe1589f6edfda70f02c117f2bf75f0b88ed..c19c47429d1395ce4153039b59a35d50a0a011c4 100644 (file)
@@ -37,7 +37,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index abe2f8e9305ef07b69e421189e5d00bee883247f..ac865604e522208f69947dc0e272b6ba6a917ea9 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index b1a7b167b2d075d213941400cb2cd5e0a4aa0858..55180439afdbdf843da7170b83d87d1848ca0dd0 100644 (file)
@@ -37,7 +37,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 90bb89748519351d0138ffd8bc67697ef01f6b48..248bd9c5db88b7ea83e2b2af8167061d6d5ba7d0 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index d83d8d42f5267f9de33235f6d82b4b54d8c927fb..fbee1f50494a56a0321e7107e20b188c2c8dbc96 100644 (file)
@@ -53,7 +53,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 790bebfb4d2b0c1378cc851c6ce2580ac0fd699c..73829a191bae6612242c1c3778e9f1d2b57a31a6 100644 (file)
@@ -53,7 +53,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index abc40ec7952f457b84620ab3da6ca9249fffafb3..6ce9c3fff7f31b2b88c99a75d04117cb5ddff40f 100644 (file)
@@ -37,7 +37,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 76e3bd79e70befcc1996d89ec6a3ed8a58c9541f..43f267c3125ec7b50231554188a53a2179f9a4d8 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index d8d2b7939f18290a63f8915e58ac7af4ad5208c8..597c477f7289638b2bdc9fa1ccbc3036de1227ab 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 698ea77af65b69ec79e7f29088612909e6565177..ad616e16ae27d00c9056c0a0416078be84974246 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 4ca53ff85d1341c9ca5fe5adeb7268b57b40208e..2155a2bf140d52c9199e8382e43bc7f60a2673a0 100644 (file)
@@ -55,7 +55,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index f2c1e2c5b8b5ee01a22560ab35bf02790b11a892..f7e614c413df6111f52289db4adf17c04bcf19c7 100644 (file)
@@ -53,7 +53,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 6ff4e10169169730100001f99583ac51fb6a2097..d264731275951510230e1e3fe91bf90fec2fef5b 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index bb8849f55c94117f3434c79e21146e3018567dfb..850ac3ca8ad78b833ca380e6d648418b16dec5a4 100644 (file)
@@ -37,7 +37,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 40b07a58f0a083fbb1dbb483aee3528b4846cf79..35d8a3c40b8b17a26407b410676f0958495cd1b2 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 5c655caff3217add94a12a59c79b239e1dd850d8..385bf0b529908fcec170d90ce91245c34daedc21 100644 (file)
@@ -37,7 +37,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index f316ab7fbdf4346fe8131de5c2076e30f041823b..5f2d68ca0508cd47e1172f3a423b6a0096176717 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index af7a11504be3e97f0c141041b196ab7fc782959a..13ab6ecbbea9aeab2ff5acf4a53f52811e9a4deb 100644 (file)
@@ -53,7 +53,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 1e44c1952c1457838b31d4488e811762a35019d1..bc4b7a48021b4f50357d30765352f7e9f86718c4 100644 (file)
@@ -37,7 +37,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 96f21561bdbbf355bce240f5e06997b012f5feb0..c585bce98276ee1f5b72860d48c3dbc44fa82979 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 7c674ffb9ccf33cc3b4864a93982e64725fd0035..b6d83c4b18f10853283f3388ff15d401146d7161 100644 (file)
@@ -53,7 +53,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index fecef3a0cf5e94c62369045009624e4c673cd0ae..17e30af5f2fd22a4d3c3f11f14cedbc5f6e0422c 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='tpm-passthrough'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 4cae4fd058679e05f7d46272539e1920503411fe..b29a6f43cbe9cae7f061aff261912d573c815f1e 100644 (file)
@@ -27,7 +27,6 @@
   <flag name='tpm-passthrough'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 1a2d1b6a5304e0af5b51de2729c5013958d3c42c..92f78ee82e50e4e6a3383261f503117894ea2ff8 100644 (file)
@@ -67,7 +67,6 @@
   <flag name='vfio-pci'/>
   <flag name='scsi-generic'/>
   <flag name='mem-merge'/>
-  <flag name='vnc-websocket'/>
   <flag name='drive-discard'/>
   <flag name='mlock'/>
   <flag name='device-del-event'/>
index 816a3055a2bc072ee11430df8a86a35470c65bc4..f4a2e83d455846392296bd5a5c0e43ebbdcbe386 100644 (file)
@@ -1233,7 +1233,8 @@ mymain(void)
 
     DO_TEST("graphics-vnc", QEMU_CAPS_VNC, QEMU_CAPS_DEVICE_CIRRUS_VGA);
     DO_TEST("graphics-vnc-socket", QEMU_CAPS_VNC, QEMU_CAPS_DEVICE_CIRRUS_VGA);
-    DO_TEST("graphics-vnc-websocket", QEMU_CAPS_VNC, QEMU_CAPS_VNC_WEBSOCKET,
+    DO_TEST("graphics-vnc-websocket",
+            QEMU_CAPS_VNC,
             QEMU_CAPS_DEVICE_CIRRUS_VGA);
     DO_TEST("graphics-vnc-policy", QEMU_CAPS_VNC,
             QEMU_CAPS_DEVICE_CIRRUS_VGA);