ip: add missing space after 'external' in detailed mode

Add a missing space after the 'external' keyword in the detailed mode
of tunnel links output:

 # ip -d link
 79: geneve1: <BROADCAST,MULTICAST> mtu 65465 qdisc noop state DOWN mode DEFAULT group default qlen 1000
     link/ether da:e9:e4:2b:f9:d4 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65465
     geneve externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
 80: vxlan1: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
     link/ether 7a:a8:19:07:da:01 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 65535
     vxlan externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
 84: gre1@NONE: <NOARP> mtu 1476 qdisc noop state DOWN mode DEFAULT group default qlen 1000
     link/none 00:00:00:00 brd 00:00:00:00 promiscuity 0 minmtu 0 maxmtu 0
     gre externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
 87: ip6gre1@NONE: <NOARP> mtu 1448 qdisc noop state DOWN mode DEFAULT group default qlen 1000
     link/gre6 :: brd :: promiscuity 0 minmtu 0 maxmtu 0
     ip6gre externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
 88: ip6tnl1@NONE: <NOARP> mtu 1452 qdisc noop state DOWN mode DEFAULT group default qlen 1000
     link/tunnel6 :: brd :: promiscuity 0 minmtu 68 maxmtu 65407
     ip6tnl externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535
 90: ipip1@NONE: <NOARP> mtu 1480 qdisc noop state DOWN mode DEFAULT group default qlen 1000
     link/ipip 0.0.0.0 brd 0.0.0.0 promiscuity 0 minmtu 0 maxmtu 0
     ipip externaladdrgenmode eui64 numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535

Fixes: 00ff4b8e31af ("ip/tunnel: Be consistent when printing tunnel collect metadata")
Reviewed-and-tested-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: Beniamino Galvani <bgalvani@redhat.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

diff --git a/ip/iplink_geneve.c b/ip/iplink_geneve.c
index 278a6e23b311a629eaeadd2c40c593d5c60a8ef8..d70b1941a885e991b76ba3eeea39ca34561d0944 100644 (file)
--- a/ip/iplink_geneve.c
+++ b/ip/iplink_geneve.c
@@ -251,7 +251,7 @@ static void geneve_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
                return;
 
        if (tb[IFLA_GENEVE_COLLECT_METADATA]) {
-               print_bool(PRINT_ANY, "external", "external", true);
+               print_bool(PRINT_ANY, "external", "external ", true);
                return;
        }
 

diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
index 497affc0c90b36492ddb7c1259e4760679fe1739..1489c00925fbecf59982197cd781c5375d7fda22 100644 (file)
--- a/ip/iplink_vxlan.c
+++ b/ip/iplink_vxlan.c
@@ -418,7 +418,7 @@ static void vxlan_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
 
        if (tb[IFLA_VXLAN_COLLECT_METADATA] &&
            rta_getattr_u8(tb[IFLA_VXLAN_COLLECT_METADATA])) {
-               print_bool(PRINT_ANY, "external", "external", true);
+               print_bool(PRINT_ANY, "external", "external ", true);
                return;
        }
 

diff --git a/ip/link_gre.c b/ip/link_gre.c
index d754fa9a3425fa89e992b53e571b12c243147a18..842fab5cdb0fb768244eb0a9820d1567cee39e53 100644 (file)
--- a/ip/link_gre.c
+++ b/ip/link_gre.c
@@ -436,7 +436,7 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
                return;
 
        if (tb[IFLA_GRE_COLLECT_METADATA]) {
-               print_bool(PRINT_ANY, "external", "external", true);
+               print_bool(PRINT_ANY, "external", "external ", true);
                return;
        }
 

diff --git a/ip/link_gre6.c b/ip/link_gre6.c
index 6c4671e5a820693b5e22ad8722f41511a1c8eddd..4710b4048c0fede57147958e47069b9e575a86d5 100644 (file)
--- a/ip/link_gre6.c
+++ b/ip/link_gre6.c
@@ -465,7 +465,7 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
                return;
 
        if (tb[IFLA_GRE_COLLECT_METADATA]) {
-               print_bool(PRINT_ANY, "external", "external", true);
+               print_bool(PRINT_ANY, "external", "external ", true);
                return;
        }
 

diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c
index 711988a150a5ad4c469c2260a8defb0bbc03da8b..8d9feab17e6a885f4b3c3e6b95613e433ecceda4 100644 (file)
--- a/ip/link_ip6tnl.c
+++ b/ip/link_ip6tnl.c
@@ -354,7 +354,7 @@ static void ip6tunnel_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb
                return;
 
        if (tb[IFLA_IPTUN_COLLECT_METADATA]) {
-               print_bool(PRINT_ANY, "external", "external", true);
+               print_bool(PRINT_ANY, "external", "external ", true);
                return;
        }
 

diff --git a/ip/link_iptnl.c b/ip/link_iptnl.c
index d4a56de40061523cd4436509c33a1be8e4d99fa7..2736ef8996b6ae6701a922f2fc57727130991c66 100644 (file)
--- a/ip/link_iptnl.c
+++ b/ip/link_iptnl.c
@@ -374,7 +374,7 @@ static void iptunnel_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[
                return;
 
        if (tb[IFLA_IPTUN_COLLECT_METADATA]) {
-               print_bool(PRINT_ANY, "external", "external", true);
+               print_bool(PRINT_ANY, "external", "external ", true);
                return;
        }