[4088] strings, options and equal tokens are now instantiated

diff --git a/src/lib/eval/eval_context.cc b/src/lib/eval/eval_context.cc
index b1482978423677a2521a1ec3a97d92228b700e6c..5ad51c1d35a6f94f46be4a0fa4a562b7d0dece85 100644 (file)
--- a/src/lib/eval/eval_context.cc
+++ b/src/lib/eval/eval_context.cc
@@ -6,8 +6,6 @@
 EvalContext::EvalContext()
   : trace_scanning (false), trace_parsing (false)
 {
-  variables["one"] = 1;
-  variables["two"] = 2;
 }
 
 EvalContext::~EvalContext()

diff --git a/src/lib/eval/eval_context.h b/src/lib/eval/eval_context.h
index 33a370c7138c6d70cf84383ae19fd3f41c61bae3..64249752e99366eb63da2003ceac3024425ae8fc 100644 (file)
--- a/src/lib/eval/eval_context.h
+++ b/src/lib/eval/eval_context.h
@@ -18,7 +18,7 @@ public:
   EvalContext ();
   virtual ~EvalContext ();
 
-  std::map<std::string, int> variables;
+  isc::dhcp::Expression expression;
 
   int result;
 

diff --git a/src/lib/eval/lexer.ll b/src/lib/eval/lexer.ll
index f048b49977a15293413290cac11327d841f050e5..e79d2294159832b7d2fbc8cb96c066331f09130a 100644 (file)
--- a/src/lib/eval/lexer.ll
+++ b/src/lib/eval/lexer.ll
@@ -35,7 +35,7 @@ blank [ \t]
 {blank}+   loc.step();
 [\n]+      loc.lines(yyleng); loc.step();
 
-\"[a-zA-Z_0-9]*\" {
+\'[a-zA-Z_0-9]*\' {
     // This is a string, no need to do any conversions here.
     return isc::eval::EvalParser::make_STRING(yytext, loc);
 }

diff --git a/src/lib/eval/parser.yy b/src/lib/eval/parser.yy
index cc621685929c98c6dae6bdef1362a8087bc07dc8..87468a48bb0f90b94b41c4a990860e478ae5a17e 100644 (file)
--- a/src/lib/eval/parser.yy
+++ b/src/lib/eval/parser.yy
@@ -11,6 +11,8 @@
 #include <string>
 #include <eval/token.h>
 class EvalContext;
+
+using namespace isc::dhcp;
 }
 // The parsing context.
 %param { EvalContext& ctx }
@@ -45,12 +47,21 @@ class EvalContext;
 
 // Expression can either be a single token or a (something == something) expression
 expression:
-token EQUAL token
+token EQUAL token {
+    TokenPtr eq(new TokenEqual());
+    ctx.expression.push_back(eq);
+}
 | token;
 
 token:
-STRING { /* push back TokenString */ }
-| OPTION { /* push back TokenOption */ }
+STRING {
+    TokenPtr str(new TokenString($1));
+    ctx.expression.push_back(str);
+}
+| OPTION {
+    TokenPtr opt(new TokenOption($1));
+    ctx.expression.push_back(opt);
+}
 | SUBSTRING "(" token "," token "," token ")" {
     /* push back TokenSubstring */
   }

diff --git a/src/lib/eval/tests/context_unittest.cc b/src/lib/eval/tests/context_unittest.cc
index 01f42d326a0ebe926dd8ad29f9cbef0200dbc767..9bb673c12fd34a3f5b29bd5139038b8bbc60f7bc 100644 (file)
--- a/src/lib/eval/tests/context_unittest.cc
+++ b/src/lib/eval/tests/context_unittest.cc
@@ -15,6 +15,8 @@
 #include <config.h>
 #include <eval/token.h>
 #include <eval/eval_context.h>
+#include <eval/token.h>
+#include <dhcp/pkt4.h>
 
 #include <boost/shared_ptr.hpp>
 #include <boost/scoped_ptr.hpp>
@@ -25,12 +27,64 @@ using namespace isc::dhcp;
 
 namespace {
 
-TEST(EvalContextTest, basic) {
+class EvalContextTest : public ::testing::Test {
+public:
+    void checkStringToken(const TokenPtr& token, const std::string& expected) {
+        ASSERT_TRUE(token);
+        boost::shared_ptr<TokenString> str = boost::dynamic_pointer_cast<TokenString>(token);
+        ASSERT_TRUE(str);
+
+        Pkt4Ptr pkt4(new Pkt4(DHCPDISCOVER, 12345));
+        ValueStack values;
+
+        EXPECT_NO_THROW(token->evaluate(*pkt4, values));
+
+        ASSERT_EQ(1, values.size());
+
+        EXPECT_EQ(expected, values.top());
+    }
+
+    void checkEqToken(const TokenPtr& token) {
+        ASSERT_TRUE(token);
+        boost::shared_ptr<TokenEqual> eq = boost::dynamic_pointer_cast<TokenEqual>(token);
+        EXPECT_TRUE(eq);
+    }
+
+};
+
+TEST_F(EvalContextTest, basic) {
 
     EvalContext tmp;
 
-    EXPECT_NO_THROW(tmp.parseString("option[123] == \"MSFT\""));
+    EXPECT_NO_THROW(tmp.parseString("option[123] == 'MSFT'"));
+}
+
+TEST_F(EvalContextTest, string) {
+    EvalContext eval;
+
+    EXPECT_NO_THROW(eval.parseString("'foo'"));
+
+    ASSERT_EQ(1, eval.expression.size());
+
+    TokenPtr tmp = eval.expression.at(0);
+
+    checkStringToken(tmp, "foo");
 }
 
+TEST_F(EvalContextTest, equal) {
+    EvalContext eval;
+
+    EXPECT_NO_THROW(eval.parseString("'foo' == 'bar'"));
+
+    ASSERT_EQ(3, eval.expression.size());
+
+    TokenPtr tmp1 = eval.expression.at(0);
+    TokenPtr tmp2 = eval.expression.at(1);
+    TokenPtr tmp3 = eval.expression.at(2);
+
+    checkStringToken(tmp1, "foo");
+    checkStringToken(tmp2, "bar");
+    checkEqToken(tmp3);
+}
 
 };