]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: uvcvideo: Flush the control cache when we get an event
authorRicardo Ribalda <ribalda@chromium.org>
Tue, 3 Dec 2024 21:20:12 +0000 (21:20 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 19 Dec 2024 14:44:43 +0000 (14:44 +0000)
Asynchronous controls trigger an event when they have completed their
operation.

This can make that the control cached value does not match the value in
the device.

Let's flush the cache to be on the safe side.

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20241203-uvc-fix-async-v6-5-26c867231118@chromium.org
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/usb/uvc/uvc_ctrl.c

index 21d5c62d1ac122979f20c2dcf3a9c6d6cf525637..4e58476d305efddac331417feda8cb064e340a13 100644 (file)
@@ -1622,6 +1622,9 @@ void uvc_ctrl_status_event(struct uvc_video_chain *chain,
 
        mutex_lock(&chain->ctrl_mutex);
 
+       /* Flush the control cache, the data might have changed. */
+       ctrl->loaded = 0;
+
        handle = ctrl->handle;
        if (handle)
                uvc_ctrl_set_handle(handle, ctrl, NULL);