dm: fix excessive blk-crypto operations for invalid keys

dm_exec_wrappedkey_op() passes through the derive_sw_secret, import_key,
generate_key, and prepare_key blk-crypto operations to an underlying
device.

Currently, it calls the operation on every underlying device until one
returns success.

This logic is flawed when the operation is expected to fail, such as an
invalid key being passed to derive_sw_secret.  That can happen if
userspace passes an invalid key to the FS_IOC_ADD_ENCRYPTION_KEY ioctl.

When that happens on a device-mapper device that consists of many
dm-linear targets, a lot of unnecessary key unwrapping requests get sent
to the underlying key wrapping hardware.

Fix this by considering the first device only.  As already documented in
the comment, it was already checked that all underlying devices support
wrapped keys, so this should be fine.

Fixes: e93912786e50 ("dm: pass through operations on wrapped inline crypto keys")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 0522cd700e0e2ddf3b1f68f83509e5fa651af7a0..4b70872725d043acc02a814decf3b5ecac78f85a 100644 (file)
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1237,9 +1237,6 @@ static int dm_wrappedkey_op_callback(struct dm_target *ti, struct dm_dev *dev,
                bdev_get_queue(bdev)->crypto_profile;
        int err = -EOPNOTSUPP;
 
-       if (!args->err)
-               return 0;
-
        switch (args->op) {
        case DERIVE_SW_SECRET:
                err = blk_crypto_derive_sw_secret(
@@ -1266,9 +1263,7 @@ static int dm_wrappedkey_op_callback(struct dm_target *ti, struct dm_dev *dev,
                break;
        }
        args->err = err;
-
-       /* Try another device in case this fails. */
-       return 0;
+       return 1; /* No need to continue the iteration. */
 }
 
 static int dm_exec_wrappedkey_op(struct blk_crypto_profile *profile,
@@ -1294,14 +1289,13 @@ static int dm_exec_wrappedkey_op(struct blk_crypto_profile *profile,
         * declared on all underlying devices.  Thus, all the underlying devices
         * should support all wrapped key operations and they should behave
         * identically, i.e. work with the same keys.  So, just executing the
-        * operation on the first device on which it works suffices for now.
+        * operation on the first device suffices for now.
         */
        for (i = 0; i < t->num_targets; i++) {
                ti = dm_table_get_target(t, i);
                if (!ti->type->iterate_devices)
                        continue;
-               ti->type->iterate_devices(ti, dm_wrappedkey_op_callback, args);
-               if (!args->err)
+               if (ti->type->iterate_devices(ti, dm_wrappedkey_op_callback, args) != 0)
                        break;
        }
 out: