]> git.ipfire.org Git - thirdparty/postgresql.git/commitdiff
Clean up nodes that are no longer of use in 007_pgdumpall.pl
authorAndrew Dunstan <andrew@dunslane.net>
Fri, 27 Feb 2026 12:14:06 +0000 (07:14 -0500)
committerAndrew Dunstan <andrew@dunslane.net>
Fri, 27 Feb 2026 12:33:50 +0000 (07:33 -0500)
Oversight in commit 763aaa06f03. When nodes are going out of scope, we
should stop the underlying postmasters rather than waiting for the
script to end.

Per gripe from Tom Lane

Discussion: https://postgr.es/m/740033.1772142754@sss.pgh.pa.us

src/bin/pg_dump/t/007_pg_dumpall.pl

index b228e572f4319eb092dd609db128d09eaae3dde3..04eba494b4e07dc9a041d09ec2d127c4ee11204f 100644 (file)
@@ -352,6 +352,9 @@ foreach my $run (sort keys %pgdumpall_runs)
                        $pgdumpall_runs{$run}->{unlike},
                        "should not dump $run");
        }
+
+       $target_node->stop;
+       $target_node->clean_node;
 }
 
 # Some negative test case with dump of pg_dumpall and restore using pg_restore