]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 337701: 012throwables.t doesn't recognize that certain errors are AUTH_ERROR...
authormkanat%bugzilla.org <>
Wed, 17 May 2006 05:07:07 +0000 (05:07 +0000)
committermkanat%bugzilla.org <>
Wed, 17 May 2006 05:07:07 +0000 (05:07 +0000)
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave

t/012throwables.t

index 2c7a5998b4af0319299f294bb24e7056f09be18d..8bc749686d11d94b4ceb59c956bd8aee2477ce6c 100644 (file)
@@ -113,9 +113,18 @@ foreach my $file (keys %test_modules) {
         last if $line =~ /^__END__/; # skip the POD (at least in
                                         # Bugzilla/Error.pm)
         $lineno++;
-        if ($line =~ /^[^#]*Throw(Code|User)Error\s*\(\s*["'](.*?)['"]/) {
-            my $errtype = lc($1);
-            my $errtag = $2;
+        if ($line =~
+/^[^#]*(Throw(Code|User)Error|error\s+=>)\s*\(?\s*["'](.*?)['"]/) {
+            my $errtype;
+            # If it's a normal ThrowCode/UserError
+            if ($2) {
+                $errtype = lc($2);
+            }
+            # If it's an AUTH_ERROR tag
+            else {
+                $errtype = 'code';
+            }
+            my $errtag = $3;
             push @{$Errors{$errtype}{$errtag}{used_in}{$file}}, $lineno;
         }
     }