]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
tree-optimization/111070 - fix ICE with recent ifcombine fix
authorRichard Biener <rguenther@suse.de>
Mon, 21 Aug 2023 07:01:00 +0000 (09:01 +0200)
committerRichard Biener <rguenther@suse.de>
Tue, 11 Jun 2024 07:12:35 +0000 (09:12 +0200)
We now got test coverage for non-SSA name bits so the following amends
the SSA_NAME_OCCURS_IN_ABNORMAL_PHI checks.

PR tree-optimization/111070
* tree-ssa-ifcombine.cc (ifcombine_ifandif): Check we have
an SSA name before checking SSA_NAME_OCCURS_IN_ABNORMAL_PHI.

* gcc.dg/pr111070.c: New testcase.

(cherry picked from commit 966b0a96523fb7adbf498ac71df5e033c70dc546)

gcc/testsuite/gcc.dg/pr111070.c [new file with mode: 0644]
gcc/tree-ssa-ifcombine.cc

diff --git a/gcc/testsuite/gcc.dg/pr111070.c b/gcc/testsuite/gcc.dg/pr111070.c
new file mode 100644 (file)
index 0000000..1ebc7ad
--- /dev/null
@@ -0,0 +1,20 @@
+/* { dg-do compile } */
+/* { dg-options "-O" } */
+
+/* common */
+char c;
+/* arrays must be 8 byte aligned, regardless of size */
+char c_ary[1];
+
+/* data */
+char d = 1;
+char d_ary[1] = {1};
+
+int main ()
+{
+  if (((unsigned long)&c_ary[0] & 7) != 0)
+    return 1;
+  if (((unsigned long)&d_ary[0] & 7) != 0)
+    return 1;
+  return 0;
+}
index b139328af224fc0e5bc42f77fde4e64a03bce5c5..dcfa92c0c821dc48cd060a47d4c610d7d83621df 100644 (file)
@@ -415,7 +415,8 @@ ifcombine_ifandif (basic_block inner_cond_bb, bool inner_inv,
     {
       tree t, t2;
 
-      if (SSA_NAME_OCCURS_IN_ABNORMAL_PHI (name1))
+      if (TREE_CODE (name1) == SSA_NAME
+         && SSA_NAME_OCCURS_IN_ABNORMAL_PHI (name1))
        return false;
 
       /* Do it.  */
@@ -468,8 +469,10 @@ ifcombine_ifandif (basic_block inner_cond_bb, bool inner_inv,
       gimple_stmt_iterator gsi;
       tree t;
 
-      if (SSA_NAME_OCCURS_IN_ABNORMAL_PHI (name1)
-         || SSA_NAME_OCCURS_IN_ABNORMAL_PHI (name2))
+      if ((TREE_CODE (name1) == SSA_NAME
+          && SSA_NAME_OCCURS_IN_ABNORMAL_PHI (name1))
+         || (TREE_CODE (name2) == SSA_NAME
+             && SSA_NAME_OCCURS_IN_ABNORMAL_PHI (name2)))
        return false;
 
       /* Find the common name which is bit-tested.  */