Close sqlite handle when we fail to pre-poopulate the database. Closes #5392

diff --git a/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c b/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c
index 658470dc1cddc24166bf195f4eb0831eea3a48d7..1ef18a881555a28dd4b36733c47892293859c6ad 100644 (file)
--- a/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c
+++ b/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c
@@ -771,7 +771,10 @@ static int mod_instantiate(module_inst_ctx_t const *mctx)
                        if (!p) continue;
 
                        ret = sql_loadfile(mctx->mi->conf, db, p);
-                       if (ret < 0) goto unlink;
+                       if (ret < 0) {
+                               (void) sqlite3_close(db);
+                               goto unlink;
+                       }
                }
 
                status = sqlite3_close(db);