]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: rtl8xxxu: Fix RX skb size for aggregation disabled
authorMartin Kaistra <martin.kaistra@linutronix.de>
Wed, 9 Jul 2025 12:15:22 +0000 (14:15 +0200)
committerPing-Ke Shih <pkshih@realtek.com>
Tue, 15 Jul 2025 02:01:36 +0000 (10:01 +0800)
Commit 1e5b3b3fe9e0 ("rtl8xxxu: Adjust RX skb size to include space for
phystats") increased the skb size when aggregation is enabled but decreased
it for the aggregation disabled case.

As a result, if a frame near the maximum size is received,
rtl8xxxu_rx_complete() is called with status -EOVERFLOW and then the
driver starts to malfunction and no further communication is possible.

Restore the skb size in the aggregation disabled case.

Fixes: 1e5b3b3fe9e0 ("rtl8xxxu: Adjust RX skb size to include space for phystats")
Signed-off-by: Martin Kaistra <martin.kaistra@linutronix.de>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250709121522.1992366-1-martin.kaistra@linutronix.de
drivers/net/wireless/realtek/rtl8xxxu/core.c

index 496836f716aa127dae4185926adb300ab8ec25c3..f6f169d2062d9d8def342836678e65875c8dfde6 100644 (file)
@@ -6618,7 +6618,7 @@ static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv,
                skb_size = fops->rx_agg_buf_size;
                skb_size += (rx_desc_sz + sizeof(struct rtl8723au_phy_stats));
        } else {
-               skb_size = IEEE80211_MAX_FRAME_LEN;
+               skb_size = IEEE80211_MAX_FRAME_LEN + rx_desc_sz;
        }
 
        skb = __netdev_alloc_skb(NULL, skb_size, GFP_KERNEL);