]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pytests: krb5 raw tests use TestCase.get_server_param()
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 13 Nov 2025 03:44:33 +0000 (16:44 +1300)
committerJennifer Sutton <jsutton@samba.org>
Thu, 20 Nov 2025 21:25:39 +0000 (21:25 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
python/samba/tests/krb5/raw_testcase.py

index 7d42b1825122e06a79612616c10d97e9e25f24fb..d2b3e8d9d4d6721a725de1aa851673ee5ba68766 100644 (file)
@@ -878,16 +878,9 @@ class RawKerberosTest(TestCase):
         # Always generating the PAC is currently only supported by
         # the Embedded heimdal
         if using_embedded_heimdal:
-            # get_loadparm loads the client smb.conf
-            # we need to load the server smb.conf to get the server
-            # settings.
-            server_conf = samba.tests.env_get_var_value('SERVERCONFFILE')
-            lp = LoadParm(filename_for_non_global_lp=server_conf)
-            always_include = lp.get("kdc always include pac")
-            if always_include is None:
-                always_include = "True"
-
-            cls.always_include_pac = bool(always_include)
+            cls.always_include_pac = cls.get_server_param(
+                "kdc always include pac",
+                True)
 
         kadmin_is_tgs = samba.tests.env_get_var_value('KADMIN_IS_TGS',
                                                       allow_missing=True)