]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
lxc_user_nic: free_groupnames: fix
authorSerge Hallyn <serge.hallyn@ubuntu.com>
Wed, 24 Jun 2015 18:07:05 +0000 (13:07 -0500)
committerSerge Hallyn <serge.hallyn@ubuntu.com>
Wed, 24 Jun 2015 18:07:05 +0000 (13:07 -0500)
lxc_user_nic was segfaulting:
lxc-user-nic[9761]: segfault at 29 ip 00007f3fb2346872 sp 00007ffdd17b2dd0 error 4 in libc-2.21.so[7f3fb22c2000+1c0000

This patch fixes it.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
src/lxc/lxc_user_nic.c

index 2f1045133d48d7388cd37cfbbcfb5ddc8223f732..af7f8b4599a5dd6af3c6bcce7ac3f4a5f9e7b625 100644 (file)
@@ -99,9 +99,11 @@ static char *get_username(void)
 
 static void free_groupnames(char **groupnames)
 {
-       char **group;
-       for (group=groupnames; group != NULL; group++)
-               free(*group);
+       int i;
+       if (!groupnames)
+               return;
+       for (i = 0; groupnames[i]; i++)
+               free(groupnames[i]);
        free(groupnames);
 }