]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
delint
authorBob Halley <halley@dnspython.org>
Tue, 20 Feb 2018 20:08:47 +0000 (12:08 -0800)
committerBob Halley <halley@dnspython.org>
Tue, 20 Feb 2018 20:08:47 +0000 (12:08 -0800)
dns/zone.py
examples/reverse.py
examples/xfr.py
pylintrc

index 657c2098c53d61fc1f05229c4703f4182db7ed52..37f23d3d362f247cc5a7ef4622b5edaa40434010 100644 (file)
@@ -155,24 +155,24 @@ class Zone(object):
 
     def iterkeys(self):
         if PY3:
-            return self.nodes.keys()
+            return self.nodes.keys() # pylint: disable=dict-keys-not-iterating
         else:
             return self.nodes.iterkeys()  # pylint: disable=dict-iter-method
 
     def keys(self):
-        return self.nodes.keys()
+        return self.nodes.keys() # pylint: disable=dict-keys-not-iterating
 
     def itervalues(self):
         if PY3:
-            return self.nodes.values()
+            return self.nodes.values() # pylint: disable=dict-values-not-iterating
         else:
             return self.nodes.itervalues()  # pylint: disable=dict-iter-method
 
     def values(self):
-        return self.nodes.values()
+        return self.nodes.values() # pylint: disable=dict-values-not-iterating
 
     def items(self):
-        return self.nodes.items()
+        return self.nodes.items() # pylint: disable=dict-items-not-iterating
 
     iteritems = items
 
index b0a867d29975ae3727c469b9877ec600d042b80c..b84017fda5c298f946a1816956830f7d782a62a1 100755 (executable)
@@ -34,9 +34,7 @@ for filename in sys.argv[1:]:
         except KeyError:
             reverse_map[rdata.address] = [name.to_text()]
 
-keys = reverse_map.keys()
-keys.sort(key=dns.ipv4.inet_aton)
-for k in keys:
+for k in sorted(reverse_map.keys(), key=dns.ipv4.inet_aton):
     v = reverse_map[k]
     v.sort()
     print(k, v)
index a7c2bb95b4b7864ce96c90f0578d9c6378b3d787..ec24b42d7232d8c7a00c5b9ffc2cf97af5ee13be 100755 (executable)
@@ -10,7 +10,5 @@ soa_answer = dns.resolver.query('dnspython.org', 'SOA')
 master_answer = dns.resolver.query(soa_answer[0].mname, 'A')
 
 z = dns.zone.from_xfr(dns.query.xfr(master_answer[0].address, 'dnspython.org'))
-names = z.nodes.keys()
-names.sort()
-for n in names:
+for n in sorted(z.nodes.keys()):
     print(z[n].to_text(n))
index bdb82db0f4844ea24f1e6edf494560f1c37570e8..2a7f7187fa4b17901caedc7fdaed7add805d55b7 100644 (file)
--- a/pylintrc
+++ b/pylintrc
@@ -40,6 +40,7 @@ disable=
     wrong-import-position,
     len-as-condition,
     eq-without-hash,
+    next-method-defined,
 
 [REPORTS]