]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
Only assign to response once
authorJosh Soref <2119212+jsoref@users.noreply.github.com>
Thu, 13 Nov 2025 15:28:44 +0000 (10:28 -0500)
committerJosh Soref <2119212+jsoref@users.noreply.github.com>
Thu, 13 Nov 2025 15:29:06 +0000 (10:29 -0500)
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
regression-tests.dnsdist/test_ProxyProtocol.py

index b01dacf55109d70eaeb706a616f2b50791b0ebcc..e72062e2ab712c4cffaba6283143ddc083c958b6 100644 (file)
@@ -589,7 +589,6 @@ class TestProxyProtocolIncoming(ProxyProtocolTest):
         destPort = 9999
         srcAddr = "2001:db8::8"
         srcPort = 8888
-        response = dns.message.make_response(query)
 
         udpPayload = ProxyProtocol.getPayload(False, False, True, srcAddr, destAddr, srcPort, destPort, [ [ 2, b'foo'], [ 3, b'proxy'] ])
         toProxyQueue.put(response, True, 2.0)
@@ -619,7 +618,6 @@ class TestProxyProtocolIncoming(ProxyProtocolTest):
         destPort = 9999
         srcAddr = "2001:db8::8"
         srcPort = 8888
-        response = dns.message.make_response(query)
 
         tcpPayload = ProxyProtocol.getPayload(False, True, True, srcAddr, destAddr, srcPort, destPort, [ [ 2, b'foo'], [ 3, b'proxy'] ])
 
@@ -661,7 +659,6 @@ class TestProxyProtocolIncoming(ProxyProtocolTest):
         destPort = 9999
         srcAddr = "2001:db8::8"
         srcPort = 8888
-        response = dns.message.make_response(query)
 
         udpPayload = ProxyProtocol.getPayload(False, False, True, srcAddr, destAddr, srcPort, destPort, [ [2, b'foo'], [3, b'proxy'], [ 50, b'initial-value']])
         toProxyQueue.put(response, True, 2.0)