can: f81604: f81604_handle_can_bus_errors(): fix {rx,tx}_errors statistics

The f81604_handle_can_bus_errors() function only incremented the receive
error counter and never the transmit error counter, even if the ECC_DIR
flag reported that an error had occurred during transmission.

Increment the receive/transmit error counter based on the value of the
ECC_DIR flag.

Fixes: 88da17436973 ("can: usb: f81604: add Fintek F81604 support")
Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Link: https://patch.msgid.link/20241122221650.633981-13-dario.binacchi@amarulasolutions.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

diff --git a/drivers/net/can/usb/f81604.c b/drivers/net/can/usb/f81604.c
index bc0c8903fe77946e252660118d15e015da6e6cdd..e0cfa1460b0b83110d5ce7ffe07bac442ce8a682 100644 (file)
--- a/drivers/net/can/usb/f81604.c
+++ b/drivers/net/can/usb/f81604.c
@@ -526,7 +526,6 @@ static void f81604_handle_can_bus_errors(struct f81604_port_priv *priv,
                netdev_dbg(netdev, "bus error interrupt\n");
 
                priv->can.can_stats.bus_error++;
-               stats->rx_errors++;
 
                if (skb) {
                        cf->can_id |= CAN_ERR_PROT | CAN_ERR_BUSERROR;
@@ -548,10 +547,15 @@ static void f81604_handle_can_bus_errors(struct f81604_port_priv *priv,
 
                        /* set error location */
                        cf->data[3] = data->ecc & F81604_SJA1000_ECC_SEG;
+               }
 
-                       /* Error occurred during transmission? */
-                       if ((data->ecc & F81604_SJA1000_ECC_DIR) == 0)
+               /* Error occurred during transmission? */
+               if ((data->ecc & F81604_SJA1000_ECC_DIR) == 0) {
+                       stats->tx_errors++;
+                       if (skb)
                                cf->data[2] |= CAN_ERR_PROT_TX;
+               } else {
+                       stats->rx_errors++;
                }
 
                set_bit(F81604_CLEAR_ECC, &priv->clear_flags);