]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
pytest: dns_aging: remind developers to use fl2003
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 11 Jun 2021 05:31:54 +0000 (17:31 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 20 Jun 2021 23:26:32 +0000 (23:26 +0000)
By "developers", I of course mean "me".

Other environments insist on secure updates, which these tests don't
do.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/dns_aging.py

index 037f15b8ef5342abf88baa88337b9844c9e0b866..619d6be69f08318eb83285b2b78c3ad835feefe7 100644 (file)
@@ -337,6 +337,12 @@ class TestDNSAging(DNSTest):
             txt = [txt]
         p = self.make_txt_update(name, txt, self.zone, ttl=ttl)
         (code, response) = self.dns_transaction_udp(p, host=SERVER_IP)
+        if code.operation & dns.DNS_RCODE == dns.DNS_RCODE_REFUSED:
+            # sometimes you might forget this
+            print("\n\ngot DNS_RCODE_REFUSED\n")
+            print("Are you running this in the fl2003 environment?\n")
+            print("try `SELFTEST_TESTENV='fl2003dc:local' make testenv`\n\n")
+
         self.assert_dns_rcode_equals(code, dns.DNS_RCODE_OK)
         return self.get_unique_txt_record(name, txt)