crypto: hifn_795x - Replace snprintf("%s") with strscpy

Replace snprintf("%s", ...) with the faster and more direct strscpy().
Check if the return value is less than 0 to detect string truncation.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index a897541f897b32a5af99da349b028ac48969d6f3..2da0894f31fd8a3b5b69396f81f301df5257dffa 100644 (file)
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -15,6 +15,7 @@
 #include <linux/mm.h>
 #include <linux/dma-mapping.h>
 #include <linux/scatterlist.h>
+#include <linux/string.h>
 #include <linux/highmem.h>
 #include <linux/crypto.h>
 #include <linux/hw_random.h>
@@ -2256,8 +2257,7 @@ static int hifn_alg_alloc(struct hifn_device *dev, const struct hifn_alg_templat
        alg->alg.init = hifn_init_tfm;
 
        err = -EINVAL;
-       if (snprintf(alg->alg.base.cra_name, CRYPTO_MAX_ALG_NAME,
-                    "%s", t->name) >= CRYPTO_MAX_ALG_NAME)
+       if (strscpy(alg->alg.base.cra_name, t->name) < 0)
                goto out_free_alg;
        if (snprintf(alg->alg.base.cra_driver_name, CRYPTO_MAX_ALG_NAME,
                     "%s-%s", t->drv_name, dev->name) >= CRYPTO_MAX_ALG_NAME)
@@ -2367,7 +2367,7 @@ static int hifn_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 
        INIT_LIST_HEAD(&dev->alg_list);
 
-       snprintf(dev->name, sizeof(dev->name), "%s", name);
+       strscpy(dev->name, name);
        spin_lock_init(&dev->lock);
 
        for (i = 0; i < 3; ++i) {