MINOR: backend: add a BUG_ON if conn mux NULL in connect_server

Currently, there seems to be no way to have the transport layer ready
but not the mux in the function connect_server. Add a BUG_ON to report
if this implicit condition is not true anymore.

This should fix coverity report from github issue #1120.

diff --git a/src/backend.c b/src/backend.c
index 66fa5ea37ae85936a354d0234f4e281811608ca6..15bab2291a44c74eb114e5b48a8349a3375a92f9 100644 (file)
--- a/src/backend.c
+++ b/src/backend.c
@@ -1585,6 +1585,11 @@ skip_reuse:
                        srv_conn->mux->reset(srv_conn);
        }
        else {
+               /* Currently there seems to be no known cases of xprt ready
+                * without the mux installed here.
+                */
+               BUG_ON(!srv_conn->mux);
+
                /* Only consider we're doing reuse if the connection was
                 * ready.
                 */