]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
misc: fastrpc: Remove kernel-side domain checks from capability ioctl
authorLing Xu <quic_lxu5@quicinc.com>
Fri, 12 Sep 2025 13:13:00 +0000 (14:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Sep 2025 13:48:45 +0000 (15:48 +0200)
Domain ID in the uAPI is misleading. Remove checks and log messages
related to 'domain' field in capability structure. Update UAPI to
mark the field as unused.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Signed-off-by: Ling Xu <quic_lxu5@quicinc.com>
Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
Link: https://lore.kernel.org/r/20250912131302.303199-3-srini@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/fastrpc.c
include/uapi/misc/fastrpc.h

index 53e88a1bc430444b17901e878cf8a47623efc0fe..2dfcf8a668061944983f69580a17a5f7848f1829 100644 (file)
@@ -1723,7 +1723,6 @@ static int fastrpc_get_info_from_kernel(struct fastrpc_ioctl_capability *cap,
        uint32_t attribute_id = cap->attribute_id;
        uint32_t *dsp_attributes;
        unsigned long flags;
-       uint32_t domain = cap->domain;
        int err;
 
        spin_lock_irqsave(&cctx->lock, flags);
@@ -1741,7 +1740,7 @@ static int fastrpc_get_info_from_kernel(struct fastrpc_ioctl_capability *cap,
        err = fastrpc_get_info_from_dsp(fl, dsp_attributes, FASTRPC_MAX_DSP_ATTRIBUTES);
        if (err == DSP_UNSUPPORTED_API) {
                dev_info(&cctx->rpdev->dev,
-                        "Warning: DSP capabilities not supported on domain: %d\n", domain);
+                        "Warning: DSP capabilities not supported\n");
                kfree(dsp_attributes);
                return -EOPNOTSUPP;
        } else if (err) {
@@ -1769,17 +1768,6 @@ static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp)
                return  -EFAULT;
 
        cap.capability = 0;
-       if (cap.domain >= FASTRPC_DEV_MAX) {
-               dev_err(&fl->cctx->rpdev->dev, "Error: Invalid domain id:%d, err:%d\n",
-                       cap.domain, err);
-               return -ECHRNG;
-       }
-
-       /* Fastrpc Capablities does not support modem domain */
-       if (cap.domain == MDSP_DOMAIN_ID) {
-               dev_err(&fl->cctx->rpdev->dev, "Error: modem not supported %d\n", err);
-               return -ECHRNG;
-       }
 
        if (cap.attribute_id >= FASTRPC_MAX_DSP_ATTRIBUTES) {
                dev_err(&fl->cctx->rpdev->dev, "Error: invalid attribute: %d, err: %d\n",
index f33d914d8f4699eddef9f9910ec2b30440c26e83..c6e2925f47e6908a72abe805125f77b31cc7b726 100644 (file)
@@ -134,7 +134,7 @@ struct fastrpc_mem_unmap {
 };
 
 struct fastrpc_ioctl_capability {
-       __u32 domain;
+       __u32 unused; /* deprecated, ignored by the kernel */
        __u32 attribute_id;
        __u32 capability;   /* dsp capability */
        __u32 reserved[4];