nvme: always punt polled uring_cmd end_io work to task_work

Commit 9ce6c9875f3e995be5fd720b65835291f8a609b1 upstream.

Currently NVMe uring_cmd completions will complete locally, if they are
polled. This is done because those completions are always invoked from
task context. And while that is true, there's no guarantee that it's
invoked under the right ring context, or even task. If someone does
NVMe passthrough via multiple threads and with a limited number of
poll queues, then ringA may find completions from ringB. For that case,
completing the request may not be sound.

Always just punt the passthrough completions via task_work, which will
redirect the completion, if needed.

Cc: stable@vger.kernel.org
Fixes: 585079b6e425 ("nvme: wire up async polling for io passthrough commands")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index acf73a91e87e75ac3f22c4bd2c2ca4868e069983..bdc70025fb53947bbd120bb5cf99af38e33434eb 100644 (file)
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -438,7 +438,6 @@ static enum rq_end_io_ret nvme_uring_cmd_end_io(struct request *req,
 {
        struct io_uring_cmd *ioucmd = req->end_io_data;
        struct nvme_uring_cmd_pdu *pdu = nvme_uring_cmd_pdu(ioucmd);
-       void *cookie = READ_ONCE(ioucmd->cookie);
 
        req->bio = pdu->bio;
        if (nvme_req(req)->flags & NVME_REQ_CANCELLED) {
@@ -451,14 +450,14 @@ static enum rq_end_io_ret nvme_uring_cmd_end_io(struct request *req,
        pdu->u.result = le64_to_cpu(nvme_req(req)->result.u64);
 
        /*
-        * For iopoll, complete it directly.
-        * Otherwise, move the completion to task work.
+        * IOPOLL could potentially complete this request directly, but
+        * if multiple rings are polling on the same queue, then it's possible
+        * for one ring to find completions for another ring. Punting the
+        * completion via task_work will always direct it to the right
+        * location, rather than potentially complete requests for ringA
+        * under iopoll invocations from ringB.
         */
-       if (cookie != NULL && blk_rq_is_poll(req))
-               nvme_uring_task_cb(ioucmd, IO_URING_F_UNLOCKED);
-       else
-               io_uring_cmd_complete_in_task(ioucmd, nvme_uring_task_cb);
-
+       io_uring_cmd_complete_in_task(ioucmd, nvme_uring_task_cb);
        return RQ_END_IO_FREE;
 }