]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: tegra210-quad: modify chip select (CS) deactivation
authorVishwaroop A <va@nvidia.com>
Wed, 16 Apr 2025 11:06:03 +0000 (11:06 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 24 Apr 2025 13:30:56 +0000 (14:30 +0100)
Modify the chip select (CS) deactivation and inter-transfer delay
execution only during the DATA_TRANSFER phase when the cs_change
flag is not set. This ensures proper CS handling and timing between
transfers while eliminating redundant operations.

Fixes: 1b8342cc4a38 ("spi: tegra210-quad: combined sequence mode")
Signed-off-by: Vishwaroop A <va@nvidia.com>
Link: https://patch.msgid.link/20250416110606.2737315-4-va@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c

index a9359b005ee8517daf1cd255982d12c244ebcc2c..159fbbfd4a388c1aad316f7d78f1b9ca0f2a5416 100644 (file)
@@ -1159,16 +1159,16 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
                                ret = -EIO;
                                goto exit;
                        }
-                       if (!xfer->cs_change) {
-                               tegra_qspi_transfer_end(spi);
-                               spi_transfer_delay_exec(xfer);
-                       }
                        break;
                default:
                        ret = -EINVAL;
                        goto exit;
                }
                msg->actual_length += xfer->len;
+               if (!xfer->cs_change && transfer_phase == DATA_TRANSFER) {
+                       tegra_qspi_transfer_end(spi);
+                       spi_transfer_delay_exec(xfer);
+               }
                transfer_phase++;
        }
        ret = 0;