]> git.ipfire.org Git - thirdparty/grub.git/commitdiff
loader/i386/multiboot_mbi: Clean up redundant code
authorAlec Brown <alec.r.brown@oracle.com>
Sat, 20 Jan 2024 02:52:51 +0000 (02:52 +0000)
committerDaniel Kiper <daniel.kiper@oracle.com>
Thu, 25 Jan 2024 17:13:33 +0000 (18:13 +0100)
In grub-core/loader/i386/multiboot_mbi.c, Coverity spotted redundant code where
the variable err was being set to GRUB_ERR_NONE and then being overwritten
later without being used. Since this is unnecessary, we can remove the code
that sets err to GRUB_ERR_NONE.

Fixes: CID 428877
Signed-off-by: Alec Brown <alec.r.brown@oracle.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/loader/i386/multiboot_mbi.c

index 11a6e224fff5cd4a59a8c404825182306835c8a8..fae5d6fb8c512ff6909ed9f8be8979381c8ee933 100644 (file)
@@ -86,7 +86,7 @@ load_kernel (grub_file_t file, const char *filename,
        return GRUB_ERR_NONE;
       }
       if (err == GRUB_ERR_UNKNOWN_OS && (header->flags & MULTIBOOT_AOUT_KLUDGE))
-       grub_errno = err = GRUB_ERR_NONE;
+       grub_errno = GRUB_ERR_NONE;
     }
   if (header->flags & MULTIBOOT_AOUT_KLUDGE)
     {