]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
powerpc/mm: Fix check of multiple 16G pages from device tree
authorRui Teng <rui.teng@linux.vnet.ibm.com>
Thu, 12 Jan 2017 09:09:06 +0000 (17:09 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 26 Nov 2017 13:51:01 +0000 (13:51 +0000)
commit 23493c121912a39f0262e0dbeb236e1d39efa4d5 upstream.

The offset of hugepage block will not be 16G, if the expected
page is more than one. Calculate the totol size instead of the
hardcode value.

Fixes: 4792adbac9eb ("powerpc: Don't use a 16G page if beyond mem= limits")
Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
Tested-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/powerpc/mm/hash_utils_64.c

index e9a8b8cfbe98c5e057990e1e419f15f809ec0dca..02139e26aac6a4f92604c12728c7f08f8a1c77bb 100644 (file)
@@ -383,7 +383,7 @@ static int __init htab_dt_scan_hugepage_blocks(unsigned long node,
        printk(KERN_INFO "Huge page(16GB) memory: "
                        "addr = 0x%lX size = 0x%lX pages = %d\n",
                        phys_addr, block_size, expected_pages);
-       if (phys_addr + (16 * GB) <= memblock_end_of_DRAM()) {
+       if (phys_addr + block_size * expected_pages <= memblock_end_of_DRAM()) {
                memblock_reserve(phys_addr, block_size * expected_pages);
                add_gpage(phys_addr, block_size, expected_pages);
        }