Stasis: Only log errors for non-declined types

When message type creation is declined via stasis.conf, certain
operations log errors assuming that the declined type is being used
before initialization or after destruction. These error messages get
quite spammy for oft used message types and should not be logged in the
first place since the message type is validly NULL.

Reported by: Matt DiMeo
........

Merged revisions 424769 from http://svn.asterisk.org/svn/asterisk/branches/13

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@424770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/main/stasis.c b/main/stasis.c
index d8e0e5afc8762efc30604e28f02d8bc6bffc266e..27bf1c9008c41beff82c9290d2c0805fd9d854bb 100644 (file)
--- a/main/stasis.c
+++ b/main/stasis.c
@@ -1132,7 +1132,9 @@ struct stasis_topic *stasis_topic_pool_get_topic(struct stasis_topic_pool *pool,
 
 void stasis_log_bad_type_access(const char *name)
 {
-       ast_log(LOG_ERROR, "Use of %s() before init/after destruction\n", name);
+       if (!stasis_message_type_declined(name)) {
+               ast_log(LOG_ERROR, "Use of %s() before init/after destruction\n", name);
+       }
 }
 
 /*! \brief A multi object blob data structure to carry user event stasis messages */