fix: nil: silence tainted scalar in client.c

Coverity detected that 'optlen' was not being checked in 'process_opt'.
This is actually already done when the OPT record was initially
parsed.  Add an INSIST to silence Coverity as is done in message.c.

Closes #5330

Merge branch '5330-tainted-scalar-in-client-c' into 'main'

See merge request isc-projects/bind9!10500