]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
chore: temporary disable tree-shaking #11586 11607/head
authorNicolas Coden <nicolas@ncoden.fr>
Thu, 22 Nov 2018 20:39:55 +0000 (21:39 +0100)
committerNicolas Coden <nicolas@ncoden.fr>
Thu, 22 Nov 2018 20:42:41 +0000 (21:42 +0100)
Despite the previous attempts to make Foundation compatible with tree shaking (#11445, #11497 and #11508), Foundation is used with side-effects (on jQuery) and cannot be considered as "without side-effects" for tree-shaking purposes.

This commit remove the "sideEffects: false" label and thus disable tree-shaking support, until the Foundation API and usage is changed to not implicitely rely on the global jQuery object.

Closes https://github.com/zurb/foundation-sites/issues/11586

Related to:
- https://github.com/zurb/foundation-sites/pull/11508
- https://github.com/zurb/foundation-sites/pull/11497
- https://github.com/zurb/foundation-sites/pull/11445

package.json

index 2e86a86fb958752d6b2f04c70265e748dfb3f22b..1ca6d4532fe207bf86b54b66bc787f3dddb9aa2f 100644 (file)
@@ -6,7 +6,6 @@
   "jsnext:main": "dist/js/foundation.esm.js",
   "esnext": "dist/js/foundation.es6.js",
   "typings": "dist/js/foundation.d.ts",
-  "sideEffects": false,
   "description": "The most advanced responsive front-end framework in the world.",
   "author": "ZURB <foundation@zurb.com> (http://foundation.zurb.com)",
   "homepage": "http://foundation.zurb.com/sites",