]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Avoid zeroing out memory and then filling it with data
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 27 Jan 2021 02:03:43 +0000 (02:03 +0000)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 27 Jan 2021 02:03:43 +0000 (02:03 +0000)
src/lib/server/cf_file.c

index e6d0b696c83cc0eb7c878c18ff8dd8c6c0eaa9fe..305c0d20ef9fb442bd2593c2cfbdaf33191160f9 100644 (file)
@@ -1047,14 +1047,13 @@ static int process_include(cf_stack_t *stack, CONF_SECTION *parent, char const *
 
                stack->depth++;
                frame = &stack->frame[stack->depth];
-
-               memset(frame, 0, sizeof(*frame));
-
-               frame->type = CF_STACK_DIR;
-               frame->directory = directory;
-               frame->parent = parent;
-               frame->current = parent;
-               frame->from_dir = true;
+               *frame = (cf_stack_frame_t){
+                       .type = CF_STACK_DIR,
+                       .directory = directory,
+                       .parent = parent,
+                       .current = parent,
+                       .from_dir = true
+               };
 
                MEM(frame->heap = fr_heap_alloc(frame->directory, filename_cmp, cf_file_heap_t, heap_id));